CHE-10656: persist 'yarn.lock' with fixed dependency versions#10694
Merged
akurinnoy merged 1 commit intoeclipse-che:masterfrom Aug 13, 2018
Merged
CHE-10656: persist 'yarn.lock' with fixed dependency versions#10694akurinnoy merged 1 commit intoeclipse-che:masterfrom
akurinnoy merged 1 commit intoeclipse-che:masterfrom
Conversation
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
benoitf
approved these changes
Aug 8, 2018
Contributor
Author
|
ci-test |
Contributor
|
ci-test build report: |
vitaliy-guliy
approved these changes
Aug 8, 2018
Contributor
Author
|
ci-test |
Contributor
|
ci-test build report: |
Contributor
|
Selenium tests execution on Eclipse Che Multiuser on OCP (https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/564/) doesn't show any regression against this Pull Request. |
benoitf
added
kind/task
ashumilova
approved these changes
Aug 10, 2018
benoitf
removed
the
status/code-review
qurben
added a commit
to qurben/che
that referenced
this pull request
Mar 20, 2019
The workspace loader uses yarn since eclipse-che#10694, but this was not added to the native build. Uses npx to not have a dependency on an installed yarn version, specify the same yarn version as the Dockerfile does. Signed-off-by: Gerben Oolbekkink <g.j.w.oolbekkink@gmail.com>
skabashnyuk
pushed a commit
to skabashnyuk/che
that referenced
this pull request
Mar 11, 2020
…e-che#10694) Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
skabashnyuk
pushed a commit
to skabashnyuk/che
that referenced
this pull request
Mar 11, 2020
The workspace loader uses yarn since eclipse-che#10694, but this was not added to the native build. Uses npx to not have a dependency on an installed yarn version, specify the same yarn version as the Dockerfile does. Signed-off-by: Gerben Oolbekkink <g.j.w.oolbekkink@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR replaces
npmwithyarnin workspace loader image. This is done to not to depend onnpmversion in docker image and to use fixed versions of dependencies including transitive ones.CQ https://dev.eclipse.org/ipzilla/show_bug.cgi?id=17113
What issues does this PR fix or reference?
fix #10656
Signed-off-by: Oleksii Kurinnyi okurinny@redhat.com