allow to set che ws agent inacive timeout in helm#10705
Merged
Conversation
ghost
approved these changes
Aug 8, 2018
ghost
approved these changes
Aug 8, 2018
sleshchenko
requested changes
Aug 9, 2018
Member
sleshchenko
left a comment
sleshchenko
left a comment
There was a problem hiding this comment.
Please consider using new property instead of deprecated one
| CHE_WORKSPACE_HTTPS__PROXY: {{ .Values.cheWorkspaceHttpsProxy }} | ||
| CHE_WORKSPACE_NO__PROXY: {{ .Values.cheWorkspaceNoProxy }} | ||
| CHE_WORKSPACE_AGENT_DEV_INACTIVE__STOP__TIMEOUT__MS: {{ .Values.global.wsAgentInactiveStopTimeout }} | ||
|
|
| gitHubClientSecret: "" | ||
| pvcClaim: "1Gi" | ||
| cheWorkspacesNamespace: "" | ||
| wsAgentInactiveStopTimeout: "0" |
Member
There was a problem hiding this comment.
I would say that it would be better to use default value here that is "-1"
| CHE_WORKSPACE_HTTP__PROXY: {{ .Values.cheWorkspaceHttpProxy }} | ||
| CHE_WORKSPACE_HTTPS__PROXY: {{ .Values.cheWorkspaceHttpsProxy }} | ||
| CHE_WORKSPACE_NO__PROXY: {{ .Values.cheWorkspaceNoProxy }} | ||
| CHE_WORKSPACE_AGENT_DEV_INACTIVE__STOP__TIMEOUT__MS: {{ .Values.global.wsAgentInactiveStopTimeout }} |
Member
There was a problem hiding this comment.
As far as I know, it is deprecated property, it is done in https://github.com/eclipse/che/blob/44588aa775e77f629eb0a0052ac20d949ab8c7c3/assembly/assembly-wsmaster-war/src/main/webapp/WEB-INF/classes/che_aliases.properties#L36 Consider using new one which is che.limits.workspace.idle.timeout
Contributor
Author
There was a problem hiding this comment.
ah! nice catch, btw I thought 0 is a default value.
sleshchenko
approved these changes
Aug 9, 2018
Member
sleshchenko
left a comment
sleshchenko
left a comment
There was a problem hiding this comment.
Now LGTM. Thanks for adding such an ability 👍 👍 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allow to set che ws agent inacive timeout in helm