Skip to content

CHE-10360: Hide the 'From Archetype' field if parent folder with pom.xml is selected#10718

Merged
vinokurig merged 10 commits intomasterfrom
CHE-10360
Aug 22, 2018
Merged

CHE-10360: Hide the 'From Archetype' field if parent folder with pom.xml is selected#10718
vinokurig merged 10 commits intomasterfrom
CHE-10360

Conversation

@vinokurig
Copy link
Copy Markdown
Contributor

@vinokurig vinokurig commented Aug 9, 2018 •
edited
Loading

What does this PR do?

Hide the 'From Archetype' input field in the Maven project type wizard if 'Parent' witch contains pom.xml is selected in the import project Wizard due to the maven archetype generation plugin restrictions.

What issues does this PR fix or reference?

#10360

Release Notes

Fix bug with the maven archetype and selected (non root) project path.

Docs PR

N/A

@vinokurig vinokurig requested a review from vparfonov August 9, 2018 14:32
@vinokurig
Copy link
Copy Markdown
Contributor Author

vinokurig commented Aug 9, 2018

ci-test

@benoitf benoitf added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/bug Outline of a bug - must adhere to the bug report template. labels Aug 9, 2018
@riuvshin
Copy link
Copy Markdown
Contributor

riuvshin commented Aug 9, 2018

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10718
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@vinokurig
Copy link
Copy Markdown
Contributor Author

vinokurig commented Aug 10, 2018

ci-test

@riuvshin
Copy link
Copy Markdown
Contributor

riuvshin commented Aug 10, 2018

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10718
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@vinokurig vinokurig changed the title CHE-10360: Hide the 'From Archetype' field if parent folder is selected [WIP] CHE-10360: Hide the 'From Archetype' field if parent folder is selected Aug 13, 2018
@vinokurig vinokurig changed the title [WIP] CHE-10360: Hide the 'From Archetype' field if parent folder is selected [WIP] CHE-10360: Hide the 'From Archetype' field if parent folder with pom.xml is selected Aug 13, 2018
@vinokurig vinokurig changed the title [WIP] CHE-10360: Hide the 'From Archetype' field if parent folder with pom.xml is selected CHE-10360: Hide the 'From Archetype' field if parent folder with pom.xml is selected Aug 14, 2018
vparfonov
vparfonov reviewed Aug 14, 2018
View reviewed changes
...n-maven-ide/src/main/java/org/eclipse/che/plugin/maven/client/wizard/MavenPagePresenter.java Outdated
.getItem(Path.valueOf(dataObject.getPath()).parent().append("pom.xml"))
.then(
result -> {
updateView(container, false);
Copy link
Copy Markdown
Contributor

@vparfonov vparfonov Aug 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think need to add some notification here, user must have information why create action disabled

Copy link
Copy Markdown
Contributor Author

@vinokurig vinokurig Aug 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@vinokurig vinokurig requested a review from skabashnyuk as a code owner August 14, 2018 14:23
@vinokurig
Copy link
Copy Markdown
Contributor Author

vinokurig commented Aug 17, 2018

ci-test

@riuvshin
Copy link
Copy Markdown
Contributor

riuvshin commented Aug 17, 2018

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10718
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@vinokurig
Copy link
Copy Markdown
Contributor Author

vinokurig commented Aug 21, 2018

ci-test

@riuvshin
Copy link
Copy Markdown
Contributor

riuvshin commented Aug 21, 2018

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10718
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@vinokurig
Copy link
Copy Markdown
Contributor Author

vinokurig commented Aug 21, 2018

ci-build

@vinokurig vinokurig merged commit 349cbe0 into master Aug 22, 2018
@vinokurig vinokurig deleted the CHE-10360 branch August 22, 2018 06:34
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Aug 22, 2018
@benoitf benoitf added this to the 6.10.0 milestone Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vparfonov vparfonov vparfonov approved these changes

@musienko-maxim musienko-maxim musienko-maxim approved these changes

Assignees

No one assigned

Labels

kind/bug Outline of a bug - must adhere to the bug report template.

Projects

None yet

Milestone

6.10.0

Development

Successfully merging this pull request may close these issues.

5 participants

@vinokurig @riuvshin @vparfonov @musienko-maxim @benoitf