Skip to content

Change steps for increasing stability tests#10736

Merged
musienko-maxim merged 6 commits intomasterfrom
quick_fix_1051
Aug 14, 2018
Merged

Change steps for increasing stability tests#10736
musienko-maxim merged 6 commits intomasterfrom
quick_fix_1051

Conversation

@musienko-maxim
Copy link
Copy Markdown
Contributor

@musienko-maxim musienko-maxim commented Aug 10, 2018 •
edited
Loading

We have 2 unstable parts in the JavaTestPluginTestNgTest and CheckFactoryWithPerUserCreatePolicyTest tests which was described in the issue

What issues does this PR fix or reference?

#10728

What does this PR do?

  • Replace checking notifications messages from Notification pop ups to Events panel
  • Add new method in the Events page object class which combine opening Events panel and wait the message
  • Remove extra checks messages from JavaTestPluginTestNgTest
    @dmytro-ndp, @vkuznyetsov, @SkorikSergey, @Ohrimenko1988

@benoitf benoitf added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/bug Outline of a bug - must adhere to the bug report template. labels Aug 10, 2018
@musienko-maxim
Copy link
Copy Markdown
Contributor Author

musienko-maxim commented Aug 10, 2018

ci-build

@dmytro-ndp
Copy link
Copy Markdown
Contributor

dmytro-ndp commented Aug 10, 2018

I would suggest don't remove notification tests notifications.waitExpectedMessageOnProgressPanelAndClosed("Test runner executed successfully."), but to put those tests into the try/catch blocks and log message with info about generic issue #10728 in case of exception.

dmytro-ndp
dmytro-ndp reviewed Aug 13, 2018
View reviewed changes
...elenium-test/src/test/java/org/eclipse/che/selenium/testrunner/JavaTestPluginTestNgTest.java Outdated

notifications.waitExpectedMessageOnProgressPanelAndClosed(
"Test runner executed successfully.");
} catch (WebDriverException ex) {
Copy link
Copy Markdown
Contributor

@dmytro-ndp dmytro-ndp Aug 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WebDriverException looks too general here. It would be better to catch the real exception you encountered here.

@musienko-maxim
Copy link
Copy Markdown
Contributor Author

musienko-maxim commented Aug 13, 2018

ci-build

@musienko-maxim musienko-maxim merged commit 324a7f6 into master Aug 14, 2018
@musienko-maxim musienko-maxim deleted the quick_fix_1051 branch August 14, 2018 07:50
@benoitf benoitf added this to the 6.10.0 milestone Aug 14, 2018
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmytro-ndp dmytro-ndp dmytro-ndp approved these changes

@vkuznyetsov vkuznyetsov vkuznyetsov approved these changes

@Ohrimenko1988 Ohrimenko1988 Ohrimenko1988 approved these changes

+1 more reviewer

@SkorikSergey SkorikSergey SkorikSergey approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

kind/bug Outline of a bug - must adhere to the bug report template.

Projects

None yet

Milestone

6.10.0

Development

Successfully merging this pull request may close these issues.

6 participants

@musienko-maxim @dmytro-ndp @vkuznyetsov @SkorikSergey @Ohrimenko1988 @benoitf