Skip to content

Selenium: Cover "Dashboard / Workspace Details / Machines" part of test plan by selenium test#10739

Merged
Ohrimenko1988 merged 42 commits intomasterfrom
selen-machines
Sep 3, 2018
Merged

Selenium: Cover "Dashboard / Workspace Details / Machines" part of test plan by selenium test#10739
Ohrimenko1988 merged 42 commits intomasterfrom
selen-machines

Conversation

@Ohrimenko1988
Copy link
Copy Markdown
Contributor

@Ohrimenko1988 Ohrimenko1988 commented Aug 10, 2018

What does this PR do?

Cover "Dashboard / Workspace Details / Machines" part of test plan by selenium test

What issues does this PR fix or reference?

Issue: #10692

Release Notes

Docs PR

@Ohrimenko1988
Create the 'WorkspaceDetailsOverviewTest' selenium test and related m…
05b0aa9 
…ethods in the page objects
@Ohrimenko1988
Merge branch 'master' of https://github.com/eclipse/che into selen-ov…
afbd6af 
…erview
@Ohrimenko1988
Add catching of known #10659 issue
8863b53
@Ohrimenko1988
Merge branch 'selen-overview' of https://github.com/eclipse/che into …
e1a7ddf 
…selen-projects
@Ohrimenko1988
Initial commit
bbfa5b6
@Ohrimenko1988
Apply formating
47b557e
@Ohrimenko1988
Do changes according to review
df0839a
@Ohrimenko1988
Merge branch 'master' of https://github.com/eclipse/che into selen-ov…
4ec732b 
…erview
@Ohrimenko1988
Add changes according to review
e1677fd
@Ohrimenko1988
Add changes according to review
235ba98
@Ohrimenko1988
Merge branch 'selen-overview' of https://github.com/eclipse/che into …
5387355 
…selen-projects
@Ohrimenko1988
Merge branch 'master' of https://github.com/eclipse/che into selen-pr…
f9cf844 
…ojects
@Ohrimenko1988
Create 'WorkspaceDetailsProjectsTest' selenium test and related pageo…
4929de2 
…bjects
@Ohrimenko1988
Merge branch 'master' of https://github.com/eclipse/che into selen-pr…
24129e1 
…ojects
@Ohrimenko1988
Merge branch 'master' of https://github.com/eclipse/che into selen-pr…
14a51ec 
…ojects
@Ohrimenko1988
Add tests methods to the 'WorkspaceDetailsProjectsTest' selenium test
060e592
@Ohrimenko1988
Merge branch 'master' of https://github.com/eclipse/che into selen-pr…
2d86169 
…ojects
@Ohrimenko1988
Do changes according to review
6006188
@Ohrimenko1988
Create 'WorkspaceDetailsMachines' selenium page object
4fa47f4
@Ohrimenko1988
Create 'WorkspaceDetailsMachinesTest' selenium test
23d06c0
@Ohrimenko1988
Merge branch 'master' of https://github.com/eclipse/che into selen-ma…
561a586 
…chines
@Ohrimenko1988
Merge branch 'master' of https://github.com/eclipse/che into selen-ma…
cc5491b 
…chines
@Ohrimenko1988
Create 'EditMachineForm' selenium pageobject
c510fb3
@Ohrimenko1988
Add checking of 'RAM' section
f0148af
@Ohrimenko1988
Merge branch 'master' of https://github.com/eclipse/che into selen-ma…
703bd92 
…chines
@Ohrimenko1988
Add new steps to the 'WorkspaceDetailsMachineActionsTest' selenium test
a8bfc1b
@Ohrimenko1988
Merge branch 'master' of https://github.com/eclipse/che into selen-ma…
1a81085 
…chines
@Ohrimenko1988
Add new usecases to the 'WorkspaceDetailsMachineActionsTest' selenium…
e140647 
… test
@Ohrimenko1988
Add checking of notification message
be28ee4
@Ohrimenko1988 Ohrimenko1988 added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Aug 10, 2018
@dmytro-ndp
Copy link
Copy Markdown
Contributor

dmytro-ndp commented Aug 11, 2018

ci-test

@riuvshin
Copy link
Copy Markdown
Contributor

riuvshin commented Aug 12, 2018

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10739
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@dmytro-ndp
Copy link
Copy Markdown
Contributor

dmytro-ndp commented Aug 12, 2018 •
edited
Loading

@Ohrimenko1988, please, take a look at failed test https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/577/Selenium_20tests_20report/failsafe-report.html#org.eclipse.che.selenium.dashboard.workspaces.detailsWorkspaceDetailsMachinesRamTest

dmytro-ndp
dmytro-ndp reviewed Aug 29, 2018
View reviewed changes
.../java/org/eclipse/che/selenium/pageobject/dashboard/workspaces/WorkspaceDetailsMachines.java
clickOnRamField(machineName);
seleniumWebDriverHelper.setValue(getRamAmountTextFieldLocator(machineName), "");

if (ramAmount.isEmpty()) {
Copy link
Copy Markdown
Contributor

@dmytro-ndp dmytro-ndp Aug 29, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense to check it at start of method to return as fast as possible.

Copy link
Copy Markdown
Contributor Author

@Ohrimenko1988 Ohrimenko1988 Aug 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, for a case when specified empty string

@Ohrimenko1988
Copy link
Copy Markdown
Contributor Author

Ohrimenko1988 commented Aug 29, 2018

ci-test

@riuvshin
Copy link
Copy Markdown
Contributor

riuvshin commented Aug 30, 2018

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10739
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@dmytro-ndp
Copy link
Copy Markdown
Contributor

dmytro-ndp commented Aug 30, 2018

ci-test

@riuvshin
Copy link
Copy Markdown
Contributor

riuvshin commented Aug 30, 2018

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10739
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@Ohrimenko1988
Copy link
Copy Markdown
Contributor Author

Ohrimenko1988 commented Aug 31, 2018

ci-test

dmytro-ndp
dmytro-ndp approved these changes Aug 31, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@dmytro-ndp dmytro-ndp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding selenium tests have passed here https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/695 according to the intermediate results.

@riuvshin
Copy link
Copy Markdown
Contributor

riuvshin commented Aug 31, 2018

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10739
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@Ohrimenko1988 Ohrimenko1988 merged commit e039763 into master Sep 3, 2018
@Ohrimenko1988 Ohrimenko1988 deleted the selen-machines branch September 3, 2018 09:33
@Ohrimenko1988 Ohrimenko1988 mentioned this pull request Sep 3, 2018
Closed
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Sep 3, 2018
@benoitf benoitf added this to the 6.11.0 milestone Sep 3, 2018
dmytro-ndp pushed a commit that referenced this pull request Sep 4, 2018
@Ohrimenko1988
Selenium: Cover "Dashboard / Workspace Details / Machines" part of te…
7ad73c4 
…st plan by selenium test (#10739)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmytro-ndp dmytro-ndp dmytro-ndp approved these changes

@musienko-maxim musienko-maxim musienko-maxim approved these changes

+1 more reviewer

@SkorikSergey SkorikSergey SkorikSergey approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

kind/task Internal things, technical debt, and to-do tasks to be performed.

Projects

None yet

Milestone

6.11.0

Development

Successfully merging this pull request may close these issues.

6 participants

@Ohrimenko1988 @dmytro-ndp @riuvshin @musienko-maxim @SkorikSergey @benoitf