Don't write files to test codebase#10765
Merged
tsmaeder merged 1 commit intoeclipse-che:5730_java_ls_pocfrom Aug 14, 2018
Merged
Don't write files to test codebase#10765tsmaeder merged 1 commit intoeclipse-che:5730_java_ls_pocfrom
tsmaeder merged 1 commit intoeclipse-che:5730_java_ls_pocfrom
Conversation
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder
added
kind/bug
tsmaeder
requested review from
Ohrimenko1988,
dmytro-ndp and
musienko-maxim
as code owners
tolusha
approved these changes
Aug 14, 2018
benoitf
removed
the
status/code-review
dmytro-ndp
reviewed
Aug 14, 2018
| write( | ||
| dotProject, | ||
| format( | ||
| Resources.toString(getResource("projects/jdt-ls-project-files/project"), UTF_8), |
Contributor
There was a problem hiding this comment.
Despite the fact that fixup looks good, this utility class shouldn't stick to concrete test project. So concrete project "projects/jdt-ls-project-files" looks odd here.
tsmaeder
added a commit
that referenced
this pull request
Aug 22, 2018
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder
added a commit
that referenced
this pull request
Aug 29, 2018
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tolusha
pushed a commit
that referenced
this pull request
Sep 5, 2018
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder
added a commit
that referenced
this pull request
Sep 13, 2018
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder
added a commit
that referenced
this pull request
Sep 20, 2018
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder
added a commit
that referenced
this pull request
Sep 26, 2018
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder
added a commit
that referenced
this pull request
Oct 1, 2018
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder
added a commit
that referenced
this pull request
Oct 5, 2018
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder
added a commit
that referenced
this pull request
Oct 12, 2018
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder
added a commit
that referenced
this pull request
Oct 16, 2018
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder
added a commit
that referenced
this pull request
Oct 17, 2018
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder
added a commit
that referenced
this pull request
Oct 17, 2018
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder
added a commit
that referenced
this pull request
Oct 17, 2018
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder
added a commit
that referenced
this pull request
Oct 17, 2018
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder
added a commit
that referenced
this pull request
Oct 17, 2018
Signed-off-by: Thomas Mäder <tmader@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a problem with importing simple java projects in selenium tests. We were writing .classpath files to a shared location, which caused intermittent failures with parallel test execution
What issues does this PR fix or reference?
#10764