CHE-10121: fix behavior of the factory's "Create" button#10778
Merged
akurinnoy merged 1 commit intoeclipse-che:masterfrom Aug 17, 2018
Merged
CHE-10121: fix behavior of the factory's "Create" button#10778akurinnoy merged 1 commit intoeclipse-che:masterfrom
akurinnoy merged 1 commit intoeclipse-che:masterfrom
Conversation
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
akurinnoy
added
kind/bug
akurinnoy
requested review from
Ohrimenko1988,
benoitf,
dmytro-ndp and
musienko-maxim
as code owners
Contributor
Author
|
ci-test |
1 similar comment
Contributor
|
ci-test |
olexii4
approved these changes
Aug 16, 2018
ashumilova
approved these changes
Aug 16, 2018
Contributor
|
ci-test build report: |
Contributor
Author
|
ci-test |
Contributor
|
ci-test build report: |
Contributor
|
Selenium tests execution on Eclipse Che Multiuser on OCP (https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/610/) doesn't show any regression against this Pull Request. |
SkorikSergey
approved these changes
Aug 17, 2018
benoitf
removed
the
status/code-review
skabashnyuk
pushed a commit
that referenced
this pull request
Jan 3, 2020
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Any invalid factory name disables the factory's "Create" button.
What issues does this PR fix or reference?
#10121
Release Notes
N/A - bugfix
Docs PR
N/A - bugfix
Signed-off-by: Oleksii Kurinnyi okurinny@redhat.com