Skip to content

Fix name of 'Java Theia(openshift)' stack#10787

Merged
2 commits merged intomasterfrom
fixTheiaOpenshiftStackName
Aug 16, 2018
Merged

Fix name of 'Java Theia(openshift)' stack#10787
2 commits merged intomasterfrom
fixTheiaOpenshiftStackName

Conversation

@SkorikSergey
Copy link
Copy Markdown
Contributor

What does this PR do?

Change name of the "Java Theia (openshift)" stack to "Java Theia on openshift" because stack names can't contain parentheses.

What issues does this PR fix or reference?

#10759

@SkorikSergey SkorikSergey added kind/bug Outline of a bug - must adhere to the bug report template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. team/che-qe labels Aug 15, 2018
@SkorikSergey SkorikSergey requested a review from a user August 15, 2018 15:01
Copy link
Copy Markdown

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OpenShift - camel case please

@ghost ghost merged commit 533c97d into master Aug 16, 2018
@ghost ghost deleted the fixTheiaOpenshiftStackName branch August 16, 2018 10:43
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Aug 16, 2018
@benoitf benoitf added this to the 6.10.0 milestone Aug 16, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Outline of a bug - must adhere to the bug report template.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants