Skip to content

Fix selenium test groups management#10791

Merged
dmytro-ndp merged 11 commits intomasterfrom
selenium-test-groups-fix
Aug 19, 2018
Merged

Fix selenium test groups management#10791
dmytro-ndp merged 11 commits intomasterfrom
selenium-test-groups-fix

Conversation

@dmytro-ndp
Copy link
Copy Markdown
Contributor

@dmytro-ndp dmytro-ndp commented Aug 15, 2018

What does this PR do?

It fixes selenium test groups management as follow:

  • it makes it possible to define the test to be executed on the different infrastructures (not all) at a time, for example, on OpenShift and K8S.
  • it moves beanshell script inside test suite xml, which looks hard to understand and to support, to the SeleniumTestHandler java class.

What issues does this PR fix or reference?

#10583

Dmytro Nochevnov added 3 commits August 14, 2018 19:49
Fix exclusion of selenium tests of certain group
f3fb2ec 
Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>
Fix filtering of test groups
b70acd9 
Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>
Move selenium test group management to the SeleniumTestHandler
f84dbc9 
Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>
@dmytro-ndp
Copy link
Copy Markdown
Contributor Author

dmytro-ndp commented Aug 15, 2018

ci-test

@benoitf benoitf added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. labels Aug 15, 2018
@riuvshin
Copy link
Copy Markdown
Contributor

riuvshin commented Aug 15, 2018

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10791
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@dmytro-ndp
Copy link
Copy Markdown
Contributor Author

dmytro-ndp commented Aug 15, 2018

ci-test

@riuvshin
Copy link
Copy Markdown
Contributor

riuvshin commented Aug 15, 2018

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10791
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@dmytro-ndp
Copy link
Copy Markdown
Contributor Author

dmytro-ndp commented Aug 15, 2018

ci-test

@riuvshin
Copy link
Copy Markdown
Contributor

riuvshin commented Aug 15, 2018

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10791
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@dmytro-ndp
Copy link
Copy Markdown
Contributor Author

dmytro-ndp commented Aug 16, 2018

ci-test

1 similar comment
@riuvshin
Copy link
Copy Markdown
Contributor

riuvshin commented Aug 16, 2018

ci-test

@musienko-maxim
Copy link
Copy Markdown
Contributor

musienko-maxim commented Aug 16, 2018

I think the logic for including/excluding groups is not simple and potentially we may forgot abou this. I think for this one, would be better create unit test for checking correct the logic.

Fix selenium test groups management
436709a 
Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>
@riuvshin
Copy link
Copy Markdown
Contributor

riuvshin commented Aug 16, 2018

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10791
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@dmytro-ndp
Copy link
Copy Markdown
Contributor Author

dmytro-ndp commented Aug 16, 2018

ci-test

@riuvshin
Copy link
Copy Markdown
Contributor

riuvshin commented Aug 17, 2018

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10791
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

Add unit tests
1b9b6ce 
Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>
@dmytro-ndp
Copy link
Copy Markdown
Contributor Author

dmytro-ndp commented Aug 17, 2018

ci-test

@riuvshin
Copy link
Copy Markdown
Contributor

riuvshin commented Aug 17, 2018

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10791
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@dmytro-ndp
Copy link
Copy Markdown
Contributor Author

dmytro-ndp commented Aug 18, 2018

ci-test

@riuvshin
Copy link
Copy Markdown
Contributor

riuvshin commented Aug 18, 2018

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10791
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@dmytro-ndp
Copy link
Copy Markdown
Contributor Author

dmytro-ndp commented Aug 18, 2018

ci-test-docker-single

@riuvshin
Copy link
Copy Markdown
Contributor

riuvshin commented Aug 19, 2018

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10791
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@dmytro-ndp dmytro-ndp merged commit 449d884 into master Aug 19, 2018
@dmytro-ndp dmytro-ndp deleted the selenium-test-groups-fix branch August 19, 2018 14:47
@dmytro-ndp dmytro-ndp added this to the 6.10.0 milestone Aug 19, 2018
@dmytro-ndp dmytro-ndp removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Aug 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@musienko-maxim musienko-maxim musienko-maxim approved these changes

@Ohrimenko1988 Ohrimenko1988 Awaiting requested review from Ohrimenko1988

Assignees

No one assigned

Labels

kind/task Internal things, technical debt, and to-do tasks to be performed.

Projects

None yet

Milestone

6.10.0

Development

Successfully merging this pull request may close these issues.

4 participants

@dmytro-ndp @riuvshin @musienko-maxim @benoitf