Merged
Conversation
ghost
requested review from
sleshchenko
reviewed
Aug 16, 2018
|
|
||
| cat /scripts/che-realm.json.erb | \ | ||
| sed -e "s@<%= scope\.lookupvar('che::che_server_url') %>@${PROTOCOL}://${CHE_HOST}@" \ | ||
| sed -e "s@<%= scope\.lookupvar('che::che_server_url') %>@${PROTOCOL}://che-${NAMESPACE}.${ROUTING_SUFFIX}@" \ |
Member
There was a problem hiding this comment.
Please make sure that Che on kubernetes won't be broken after reverting changes introduced in https://github.com/eclipse/che/pull/10509/files#diff-48382692058266aaf66d0fc1105bb4bbR21
benoitf
added
kind/bug
sleshchenko
approved these changes
Aug 16, 2018
Member
sleshchenko
left a comment
sleshchenko
left a comment
There was a problem hiding this comment.
Now it looks good to me 👍
benoitf
removed
the
status/code-review
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes regression introduced by https://github.com/eclipse/che/pull/10509/files
For some reason, sed commands was modified and as a result keycloak script never substitutes placeholders with actual urls.