Skip to content

Make clickable the whole workspace item row in workspaces list of an organization#10814

Merged
akurinnoy merged 1 commit intoeclipse-che:masterfrom
akurinnoy:CHE-9148
Aug 17, 2018
Merged

Make clickable the whole workspace item row in workspaces list of an organization#10814
akurinnoy merged 1 commit intoeclipse-che:masterfrom
akurinnoy:CHE-9148

Conversation

@akurinnoy
Copy link
Copy Markdown
Contributor

What does this PR do?

This PR adds a fix to make clickable the whole workspace item row in workspaces list of an organization.
Excluding action buttons, previously clickable was only workspace name.

What issues does this PR fix or reference?

#9148

@akurinnoy akurinnoy added kind/bug Outline of a bug - must adhere to the bug report template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Aug 17, 2018
@akurinnoy akurinnoy self-assigned this Aug 17, 2018
@akurinnoy akurinnoy requested a review from benoitf as a code owner August 17, 2018 07:26
For workspace item in the organization's workspaces list added ng-click
directive to columns 'RAM', 'Projects' and 'Stack' to redirect to
Workspace Overview page.

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
@sleshchenko
Copy link
Copy Markdown
Member

Please fix PR title since it will be used for changes log and the current one is not self-explaining at all.

@akurinnoy akurinnoy changed the title fix for #10750 Make clickable the whole workspace item row in workspaces list of an organization Aug 17, 2018
@akurinnoy
Copy link
Copy Markdown
Contributor Author

@sleshchenko Thanks, fixed

@akurinnoy akurinnoy merged commit 0d27a2c into eclipse-che:master Aug 17, 2018
@akurinnoy akurinnoy deleted the CHE-9148 branch August 17, 2018 12:52
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Aug 17, 2018
@benoitf benoitf added this to the 6.10.0 milestone Aug 17, 2018
skabashnyuk pushed a commit that referenced this pull request Jan 3, 2020
… organization (#10814)

For workspace item in the organization's workspaces list added ng-click
directive to columns 'RAM', 'Projects' and 'Stack' to redirect to
Workspace Overview page.

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Outline of a bug - must adhere to the bug report template.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants