Selenium: remove info about known issues, fix unstable tests#10851
Merged
SkorikSergey merged 5 commits intomasterfrom Aug 20, 2018
Merged
Selenium: remove info about known issues, fix unstable tests#10851SkorikSergey merged 5 commits intomasterfrom
SkorikSergey merged 5 commits intomasterfrom
Conversation
SkorikSergey
added
status/code-review
SkorikSergey
requested review from
Ohrimenko1988 and
musienko-maxim
as code owners
dmytro-ndp
reviewed
Aug 20, 2018
| assertFalse( | ||
| createFactoryPage.isCreateFactoryButtonEnabled(), | ||
| "Known issue https://github.com/eclipse/che/issues/10121"); | ||
| assertTrue(createFactoryPage.isCreateFactoryButtonEnabled()); |
Contributor
There was a problem hiding this comment.
There should be assertFalse according to fixing test.
dmytro-ndp
reviewed
Aug 20, 2018
| Wait fluentWait = | ||
| new FluentWait(seleniumWebDriver) | ||
| .withTimeout(LOAD_PAGE_TIMEOUT_SEC, SECONDS) | ||
| .withTimeout(WIDGET_TIMEOUT_SEC, SECONDS) |
Contributor
There was a problem hiding this comment.
WIDGET_TIMEOUT_SEC is too long timeout IMHO.
dmytro-ndp
approved these changes
Aug 20, 2018
benoitf
removed
the
status/code-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR:
What issues does this PR fix or reference?
#10848, #10849