Jdt.ls: fix few Selenium tests for Refactoring feature #10965
Merged
vparfonov merged 3 commits into5730_java_ls_pocfrom Aug 28, 2018
Merged
Jdt.ls: fix few Selenium tests for Refactoring feature #10965vparfonov merged 3 commits into5730_java_ls_pocfrom
vparfonov merged 3 commits into5730_java_ls_pocfrom
Conversation
Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>
vparfonov
requested review from
Ohrimenko1988,
dmytro-ndp and
musienko-maxim
as code owners
vparfonov
requested review from
svor
and removed request for
Ohrimenko1988 and
dmytro-ndp
Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>
dmytro-ndp
reviewed
Aug 28, 2018
| if (refactor.isWidgetOpened()) { | ||
| refactor.clickCancelButtonRefactorForm(); | ||
| } | ||
| if (editor.isAnyTabsOpened()) { |
Contributor
There was a problem hiding this comment.
Please, add empty line before second if to improve readability.
benoitf
added
target/branch
Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>
svor
approved these changes
Aug 28, 2018
musienko-maxim
approved these changes
Aug 28, 2018
benoitf
removed
the
status/code-review
tsmaeder
pushed a commit
that referenced
this pull request
Aug 29, 2018
* Fix few Refactoring tests Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>
tolusha
pushed a commit
that referenced
this pull request
Sep 5, 2018
* Fix few Refactoring tests Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>
tsmaeder
pushed a commit
that referenced
this pull request
Sep 13, 2018
* Fix few Refactoring tests Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>
tsmaeder
pushed a commit
that referenced
this pull request
Sep 20, 2018
* Fix few Refactoring tests Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>
tsmaeder
pushed a commit
that referenced
this pull request
Sep 26, 2018
* Fix few Refactoring tests Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 1, 2018
* Fix few Refactoring tests Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 5, 2018
* Fix few Refactoring tests Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 12, 2018
* Fix few Refactoring tests Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 16, 2018
* Fix few Refactoring tests Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 17, 2018
* Fix few Refactoring tests Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 17, 2018
* Fix few Refactoring tests Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 17, 2018
* Fix few Refactoring tests Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 17, 2018
* Fix few Refactoring tests Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 17, 2018
* Fix few Refactoring tests Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What issues does this PR fix or reference?
#9591