Do not set incorrect presentable text marker for pom file#10968
Merged
RomanNikitenko merged 1 commit intomasterfrom Aug 29, 2018
Merged
Do not set incorrect presentable text marker for pom file#10968RomanNikitenko merged 1 commit intomasterfrom
RomanNikitenko merged 1 commit intomasterfrom
Conversation
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
RomanNikitenko
added
kind/bug
Member
Author
|
ci-test |
vzhukovs
approved these changes
Aug 28, 2018
Contributor
|
ci-test build report: |
vparfonov
approved these changes
Aug 29, 2018
Contributor
|
Selenium tests execution on Eclipse Che Multiuser on OCP (https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/666/) doesn't show any regression against this Pull Request. |
32 tasks
RomanNikitenko
removed
the
status/code-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Current behavior: editor tab for pom.xml file has "unknown" title when maven model is broken
New behavior: editor tab for pom.xml file has "pom.xml" title when maven model is broken
What issues does this PR fix or reference?
#10755
Signed-off-by: Roman Nikitenko rnikiten@redhat.com