Fix tests in org.eclipse.che.selenium.editor.autocomplete#10975
Merged
svor merged 1 commit into5730_java_ls_pocfrom Aug 30, 2018
Merged
Fix tests in org.eclipse.che.selenium.editor.autocomplete#10975svor merged 1 commit into5730_java_ls_pocfrom
svor merged 1 commit into5730_java_ls_pocfrom
Conversation
svor
added
kind/bug
svor
requested review from
Ohrimenko1988,
dmytro-ndp,
musienko-maxim and
vparfonov
as code owners
tsmaeder
requested changes
Aug 29, 2018
| popupElement.appendChild(headerElement); | ||
|
|
||
| popupBodyElement = Elements.createDivElement(popupResources.popupStyle().body()); | ||
| popupBodyElement.setClassName("signaturesContent"); |
Contributor
There was a problem hiding this comment.
Isn't gwt-debug-id the way to go here?
| * @return true - if {@code expectedText} is present in javadoc body, false - if not | ||
| */ | ||
| public boolean waitAndCheckTextPresenceInJavaDoc(String expectedText) { | ||
| seleniumWebDriverHelper.moveCursorTo(By.xpath(JAVA_DOC_POPUP)); |
Contributor
There was a problem hiding this comment.
Is Javadoc still a thing? Shouldn't this be some generic language server popup?
Contributor
Author
There was a problem hiding this comment.
renamed to TEXT_VIEW_TOOLTIP
.../test/java/org/eclipse/che/selenium/editor/autocomplete/AutocompleteProposalJavaDocTest.java
Show resolved
Hide resolved
tsmaeder
force-pushed
the
5730_java_ls_poc
branch
from
b3033ac to
9d7bee0
Compare
svor
requested review from
ashumilova,
dkulieshov,
riuvshin,
skabashnyuk and
tolusha
as code owners
svor
removed request for
ashumilova,
dkulieshov,
riuvshin,
skabashnyuk and
vparfonov
Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
tsmaeder
approved these changes
Aug 30, 2018
benoitf
removed
the
status/code-review
tolusha
pushed a commit
that referenced
this pull request
Sep 5, 2018
Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
tsmaeder
pushed a commit
that referenced
this pull request
Sep 13, 2018
Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
tsmaeder
pushed a commit
that referenced
this pull request
Sep 20, 2018
Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
tsmaeder
pushed a commit
that referenced
this pull request
Sep 26, 2018
Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 1, 2018
Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 5, 2018
Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 12, 2018
Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 16, 2018
Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 17, 2018
Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 17, 2018
Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 17, 2018
Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 17, 2018
Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 17, 2018
Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Valeriy Svydenko vsvydenk@redhat.com
What does this PR do?
Fixes tests in
autocompletepackageWhat issues does this PR fix or reference?
#10974
Release Notes
Docs PR