Simplify jdtls pr#10984
Merged
tsmaeder merged 2 commits intoeclipse-che:5730_java_ls_pocfrom Aug 29, 2018
Merged
Conversation
Signed-off-by: Thomas Mäder <tmader@redhat.com>
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder
added
status/code-review
benoitf
reviewed
Aug 29, 2018
| @@ -1,5 +1,5 @@ | |||
| -- | |||
| -- Copyright (c) 2012-2018 Red Hat, Inc. | |||
| -- Copyright (c) 2012-2017 Red Hat, Inc. | |||
Contributor
There was a problem hiding this comment.
it seems that there are some leftover 2017 dates on these sql files that should not have been changed
Member
There was a problem hiding this comment.
@benoitf you're right. These changes must be excluded from this PR since flyway evaluates hash of content and uses it to ensure that the right migration scripts are applied.
Contributor
There was a problem hiding this comment.
in fact it's ok I read too fast :-) Thomas is putting back the dates to avoid master changes. please ignore my remark
Member
There was a problem hiding this comment.
=) As well as my comment ) I saw that these sql files are modified and missed that this PR is not targetted to master branch =)
So, please mark this thread as resolved )
benoitf
reviewed
Aug 29, 2018
| <exclude>**/*.txt</exclude> | ||
| <exclude>**/*.jpg</exclude> | ||
| <exclude>**/*.rsc</exclude> | ||
| <exclude>**/*.json</exclude> |
Contributor
There was a problem hiding this comment.
do we need all these excludes ? it seems this module doesn't contain all these kind of files
Contributor
Author
There was a problem hiding this comment.
This is all dead code!
Contributor
There was a problem hiding this comment.
yes pls ignore my comment :-)
benoitf
approved these changes
Aug 29, 2018
benoitf
removed
the
status/code-review
tolusha
pushed a commit
that referenced
this pull request
Sep 5, 2018
* Restore jdt ui dependencies * Undo spurious copyright changes Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder
added a commit
that referenced
this pull request
Sep 13, 2018
* Restore jdt ui dependencies * Undo spurious copyright changes Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder
added a commit
that referenced
this pull request
Sep 20, 2018
* Restore jdt ui dependencies * Undo spurious copyright changes Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder
added a commit
that referenced
this pull request
Sep 26, 2018
* Restore jdt ui dependencies * Undo spurious copyright changes Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder
added a commit
that referenced
this pull request
Oct 1, 2018
* Restore jdt ui dependencies * Undo spurious copyright changes Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder
added a commit
that referenced
this pull request
Oct 5, 2018
* Restore jdt ui dependencies * Undo spurious copyright changes Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder
added a commit
that referenced
this pull request
Oct 12, 2018
* Restore jdt ui dependencies * Undo spurious copyright changes Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder
added a commit
that referenced
this pull request
Oct 16, 2018
* Restore jdt ui dependencies * Undo spurious copyright changes Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder
added a commit
that referenced
this pull request
Oct 17, 2018
* Restore jdt ui dependencies * Undo spurious copyright changes Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder
added a commit
that referenced
this pull request
Oct 17, 2018
* Restore jdt ui dependencies * Undo spurious copyright changes Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder
added a commit
that referenced
this pull request
Oct 17, 2018
* Restore jdt ui dependencies * Undo spurious copyright changes Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder
added a commit
that referenced
this pull request
Oct 17, 2018
* Restore jdt ui dependencies * Undo spurious copyright changes Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder
added a commit
that referenced
this pull request
Oct 17, 2018
* Restore jdt ui dependencies * Undo spurious copyright changes Signed-off-by: Thomas Mäder <tmader@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes some changes from the jdt.ls branch (mostly removals) to reduce the number of changes in the jdt.ls branch
What issues does this PR fix or reference?
#10983