Make tests stable in projectexplorer package#10990
Merged
tolusha merged 2 commits into5730_java_ls_pocfrom Sep 3, 2018
Merged
Conversation
Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
tolusha
requested review from
Ohrimenko1988,
dmytro-ndp and
musienko-maxim
as code owners
tsmaeder
requested changes
Aug 30, 2018
|
|
||
| /** Hides context menu. */ | ||
| public void hideContextMenu() { | ||
| actionsFactory.createAction(seleniumWebDriver).moveByOffset(-1, -1).click().build().perform(); |
Contributor
There was a problem hiding this comment.
What are we clicking here? Maybe would be better?
Contributor
Author
There was a problem hiding this comment.
To close context menu we have to click outside of it. So we move a mouse not far from menu and perform click.
Contributor
There was a problem hiding this comment.
You can simplify this:
getAction().moveByOffset(-1, -1).click().perform();
Contributor
There was a problem hiding this comment.
I was thinking of typing escape, but github took that as a tag 🤦♂️
Contributor
Author
There was a problem hiding this comment.
Unfortunately escape does n't close context menu in che.
|
|
||
| Actions action = actionsFactory.createAction(seleniumWebDriver); | ||
| action.moveToElement(waitAndGetItem(path)).contextClick().perform(); | ||
| for (int i = 1; ; i++) { |
Contributor
There was a problem hiding this comment.
Could you explain what the problem was here and how the current code fixes it?
Contributor
Author
There was a problem hiding this comment.
Selecting item and invoking context menu are two separate operations.
If some item retakes focus then context menu is invoked at wrong item. It might happen because project explorer updates asynchronously and new appeared items retake focus.
So, there are two tries to invoke context menu at correct item
...ium/che-selenium-test/src/main/java/org/eclipse/che/selenium/pageobject/ProjectExplorer.java
Show resolved
Hide resolved
benoitf
added
target/branch
dmytro-ndp
reviewed
Aug 30, 2018
| try { | ||
| waitItemIsSelected(path, REDRAW_UI_ELEMENTS_TIMEOUT_SEC); | ||
| return; | ||
| } catch (WebDriverException e) { |
Contributor
There was a problem hiding this comment.
WebDriverException looks too general here. There is, for example, UnreachableBrowserException type of WebDriverException after which it doesn't make sense to repeat operation again.
TimeoutException would be enough in case of waiting for web element.
Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
tsmaeder
approved these changes
Sep 3, 2018
benoitf
removed
the
status/code-review
tolusha
added a commit
that referenced
this pull request
Sep 5, 2018
* Make tests stable in projectexplorer package Signed-off-by: Anatoliy Bazko <abazko@redhat.com> * Fix remarks Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
tsmaeder
pushed a commit
that referenced
this pull request
Sep 13, 2018
* Make tests stable in projectexplorer package Signed-off-by: Anatoliy Bazko <abazko@redhat.com> * Fix remarks Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
tsmaeder
pushed a commit
that referenced
this pull request
Sep 20, 2018
* Make tests stable in projectexplorer package Signed-off-by: Anatoliy Bazko <abazko@redhat.com> * Fix remarks Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
tsmaeder
pushed a commit
that referenced
this pull request
Sep 26, 2018
* Make tests stable in projectexplorer package Signed-off-by: Anatoliy Bazko <abazko@redhat.com> * Fix remarks Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 1, 2018
* Make tests stable in projectexplorer package Signed-off-by: Anatoliy Bazko <abazko@redhat.com> * Fix remarks Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 5, 2018
* Make tests stable in projectexplorer package Signed-off-by: Anatoliy Bazko <abazko@redhat.com> * Fix remarks Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 12, 2018
* Make tests stable in projectexplorer package Signed-off-by: Anatoliy Bazko <abazko@redhat.com> * Fix remarks Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 16, 2018
* Make tests stable in projectexplorer package Signed-off-by: Anatoliy Bazko <abazko@redhat.com> * Fix remarks Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 17, 2018
* Make tests stable in projectexplorer package Signed-off-by: Anatoliy Bazko <abazko@redhat.com> * Fix remarks Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 17, 2018
Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 17, 2018
Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 17, 2018
Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 17, 2018
Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anatoliy Bazko abazko@redhat.com
What does this PR do?
Makes tests stable in projectexplorer package
Release Notes
Docs PR