Add che.workspace.plugin_registry_url information to workspace/settings Rest method#11015
Add che.workspace.plugin_registry_url information to workspace/settings Rest method#11015skabashnyuk merged 8 commits intomasterfrom
Conversation
…/settings REST method
…rkspace/settings REST method
…n to workspace/settings REST method
benoitf
added
status/code-review
|
ci-test |
|
ci-test build report: |
skabashnyuk
changed the title
|
ci-test |
|
Please, recheck your PR since I merged my PR with walking skeleton and they might conflict/duplicate things. |
sleshchenko
left a comment
sleshchenko
left a comment
There was a problem hiding this comment.
LGTM
Please take a look my inlined comments
| # plugins dependencies to a workspace | ||
| che.workspace.plugin_broker.image=eclipse/che-plugin-broker:latest | ||
|
|
||
| # Workspace tooling plugins registry endpoint. Should be a valid HTTP URL that includes protocol, port etc. |
There was a problem hiding this comment.
I think that includes protocol, port etc. doesn't make property format clear enough. I would be useful to have example value as well.
| Joiner.on(",").join(workspaceManager.getSupportedRecipes()), | ||
| CHE_WORKSPACE_AUTO_START, | ||
| Boolean.toString(cheWorkspaceAutoStart)); | ||
| if (pluginRegistryUrl == null) { |
There was a problem hiding this comment.
I think it would be better to rewrite this method with using Map builder.
Builder<String, String> settings = ImmutableMap.builder();
settings.put(Constants.SUPPORTED_RECIPE_TYPES, Joiner.on(",").join(workspaceManager.getSupportedRecipes()));
settings.put(CHE_WORKSPACE_AUTO_START, Boolean.toString(cheWorkspaceAutoStart));
if (pluginRegistryUrl != null) {
settings.put(CHE_WORKSPACE_PLUGIN_REGISTRY_ULR, pluginRegistryUrl);
}
return settings.build();| public static final String WS_AGENT_PROCESS_NAME = "CheWsAgent"; | ||
|
|
||
| public static final String CHE_WORKSPACE_AUTO_START = "che.workspace.auto_start"; | ||
| public static final String CHE_WORKSPACE_PLUGIN_REGISTRY_ULR = |
There was a problem hiding this comment.
Please add few words to describe in which way this property supposed to be used (exposed by settings method).
|
|
||
| # Workspace tooling plugins registry endpoint. Should be a valid HTTP URL that includes protocol, port etc. | ||
| # Workspace tooling plugins registry endpoint. Should be a valid HTTP URL. | ||
| # Example: http://che-plugin-registry-eclipse-che.192.168.65.2.nip.io/plugins |
There was a problem hiding this comment.
index.json is not in plugins folder, so we should not add it in the URL
|
ci-test |
|
ci-test build report: |
|
@sleshchenko @garagatyi looks like tests are ok. I'm going to merge this pr. |
|
👍 |
benoitf
removed
the
status/code-review
|
@ashumilova FYI |
…gs Rest method (#11015) Add che.workspace.plugin_registry_url information to workspace/settings Rest method
5 participants
What does this PR do?
Add che.workspace.plugin_registry_url information to workspace/settings Rest method
What issues does this PR fix or reference?
Add public link for che-plugin-registry #10918
Release Notes
Add public link for che-plugin-registry
Docs PR
n/a