Correct the tests in the 'factory' package related to get rid from test repositories on GitHub#11019
Conversation
artaleks9
added
status/code-review
artaleks9
requested review from
Ohrimenko1988 and
musienko-maxim
as code owners
|
ci-test |
| testFactoryWithKeepDir = | ||
| testFactoryInitializer.fromUrl( | ||
| "https://github.com/" + gitHubUsername + "/gitPullTest/tree/master/my-lib"); | ||
| // preconditions - create the test repository |
There was a problem hiding this comment.
Test repo has actually created earlier, and here we are adding project into the test repo.
| public void setUp() throws Exception { | ||
| testFactoryWithRootFolder = | ||
| testFactoryInitializer.fromUrl("https://github.com/" + gitHubUsername + "/quickstart"); | ||
| // preconditions - create test the repository |
There was a problem hiding this comment.
Test repo has actually created earlier, and here we are adding project into the test repo.
|
|
||
| @BeforeClass | ||
| public void setUp() throws Exception { | ||
| // preconditions - create test the repository |
There was a problem hiding this comment.
Test repo has actually created earlier, and here we are adding project into the test repo.
| UPDATING_PROJECT_TIMEOUT_SEC); | ||
| events.waitExpectedMessage( | ||
| "Project: gitPullTest | cloned from: gitPullTest | remote branch: refs/remotes/origin/contrib-12092015 | local branch: contrib-12092015", | ||
| "Project: " |
There was a problem hiding this comment.
This multi row string looks not good. i would better to use Strng.format() to add variate part into the string.
|
ci-test build report: |
|
ci-test |
|
ci-test build report: |
|
ci-test |
|
ci-test build report: |
| @Inject private TestWorkspaceServiceClient workspaceServiceClient; | ||
| @Inject private TestProjectServiceClient testProjectServiceClient; | ||
| @Inject private PullRequestPanel pullRequestPanel; | ||
| @Inject private TestGitHubRepository testRepo; |
There was a problem hiding this comment.
You can declare it like the follow to create test repo as auxiliary github user:
@Inject
@Named(AUXILIARY)
private TestGitHubRepository testAuxiliaryRepo;
benoitf
removed
the
status/code-review
5 participants
What does this PR do?
What issues does this PR fix or reference?
#10890