Use notifications instead of client commands#11057
Merged
tsmaeder merged 1 commit intoeclipse-che:5730_java_ls_pocfrom Sep 6, 2018
Merged
Use notifications instead of client commands#11057tsmaeder merged 1 commit intoeclipse-che:5730_java_ls_pocfrom
tsmaeder merged 1 commit intoeclipse-che:5730_java_ls_pocfrom
Conversation
tsmaeder
added
kind/bug
svor
reviewed
Sep 4, 2018
| <dependency> | ||
| <groupId>org.eclipse.lsp4j</groupId> | ||
| <artifactId>org.eclipse.lsp4j</artifactId> | ||
| <version>0.4.0</version> |
Contributor
There was a problem hiding this comment.
it is not necessary to put the version here
svor
approved these changes
Sep 4, 2018
tolusha
approved these changes
Sep 5, 2018
tolusha
force-pushed
the
5730_java_ls_poc
branch
from
549b240 to
6c2d0b9
Compare
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder
force-pushed
the
11053_use_notifications
branch
from
0adbc75 to
0bd8dbf
Compare
benoitf
removed
the
status/code-review
tsmaeder
added a commit
that referenced
this pull request
Sep 13, 2018
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder
added a commit
that referenced
this pull request
Sep 20, 2018
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder
added a commit
that referenced
this pull request
Sep 26, 2018
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder
added a commit
that referenced
this pull request
Oct 1, 2018
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder
added a commit
that referenced
this pull request
Oct 5, 2018
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder
added a commit
that referenced
this pull request
Oct 12, 2018
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder
added a commit
that referenced
this pull request
Oct 16, 2018
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder
added a commit
that referenced
this pull request
Oct 17, 2018
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder
added a commit
that referenced
this pull request
Oct 17, 2018
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder
added a commit
that referenced
this pull request
Oct 17, 2018
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder
added a commit
that referenced
this pull request
Oct 17, 2018
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder
added a commit
that referenced
this pull request
Oct 17, 2018
Signed-off-by: Thomas Mäder <tmader@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use custom notifications instead of client commands for events in jdt.ls
What issues does this PR fix or reference?
#11053
This PR depends on companions
eclipse-che/che-ls-jdt#73 and
eclipse-jdtls/eclipse.jdt.ls#779