Skip to content

Fix tests from languageserver package#11059

Merged
svor merged 3 commits into5730_java_ls_pocfrom
lanser
Sep 4, 2018
Merged

Fix tests from languageserver package#11059
svor merged 3 commits into5730_java_ls_pocfrom
lanser

Conversation

@svor
Copy link
Copy Markdown
Contributor

@svor svor commented Sep 4, 2018

Signed-off-by: Valeriy Svydenko vsvydenk@redhat.com

What does this PR do?

Fixes tests from languageserver package:

  • JsonFileEditingTest
  • YamlFileEditingTest

What issues does this PR fix or reference?

#11058

Release Notes

Docs PR

Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
@svor svor added kind/bug Outline of a bug - must adhere to the bug report template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. target/branch Indicates that a PR will be merged into a branch other than master. team/languages labels Sep 4, 2018
@svor svor self-assigned this Sep 4, 2018
@svor svor requested a review from tolusha September 4, 2018 11:43
Copy link
Copy Markdown
Contributor

@tsmaeder tsmaeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the necessity of all of it, but it looks harmless, in any case.

Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
@svor
Copy link
Copy Markdown
Contributor Author

svor commented Sep 4, 2018

@SkorikSergey take a look please

@svor svor requested a review from SkorikSergey September 4, 2018 12:32
Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
@svor svor merged commit 5c3827a into 5730_java_ls_poc Sep 4, 2018
@svor svor deleted the lanser branch September 4, 2018 14:23
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Sep 4, 2018
tolusha pushed a commit that referenced this pull request Sep 5, 2018
tsmaeder pushed a commit that referenced this pull request Sep 13, 2018
tsmaeder pushed a commit that referenced this pull request Sep 20, 2018
tsmaeder pushed a commit that referenced this pull request Sep 26, 2018
tsmaeder pushed a commit that referenced this pull request Oct 1, 2018
tsmaeder pushed a commit that referenced this pull request Oct 5, 2018
tsmaeder pushed a commit that referenced this pull request Oct 12, 2018
tsmaeder pushed a commit that referenced this pull request Oct 16, 2018
tsmaeder pushed a commit that referenced this pull request Oct 17, 2018
tsmaeder pushed a commit that referenced this pull request Oct 17, 2018
Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
tsmaeder pushed a commit that referenced this pull request Oct 17, 2018
Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
tsmaeder pushed a commit that referenced this pull request Oct 17, 2018
Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
tsmaeder pushed a commit that referenced this pull request Oct 17, 2018
Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Outline of a bug - must adhere to the bug report template. target/branch Indicates that a PR will be merged into a branch other than master.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants