Skip to content

Moved plugin broker to runtime start phase instead of context preparing#11061

Merged
sleshchenko merged 1 commit intoeclipse-che:masterfrom
sleshchenko:movePluginBrokerToRuntimeStart
Sep 6, 2018
Merged

Moved plugin broker to runtime start phase instead of context preparing#11061
sleshchenko merged 1 commit intoeclipse-che:masterfrom
sleshchenko:movePluginBrokerToRuntimeStart

Conversation

@sleshchenko
Copy link
Copy Markdown
Member

@sleshchenko sleshchenko commented Sep 4, 2018

What does this PR do?

The purpose of this PR is moving plugin broker to runtime start phase instead of context preparing. To make it possible provisioning of KubernetesEnvironment is moved to runtime start phase too.

What issues does this PR fix or reference?

#11042

Release Notes

N/A

Docs PR

N/A

@sleshchenko sleshchenko added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. labels Sep 4, 2018
@sleshchenko sleshchenko self-assigned this Sep 4, 2018
@sleshchenko
Copy link
Copy Markdown
Member Author

ci-test

Copy link
Copy Markdown

@garagatyi garagatyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Great job!

@riuvshin
Copy link
Copy Markdown
Contributor

riuvshin commented Sep 5, 2018

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:11061
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@sleshchenko sleshchenko force-pushed the movePluginBrokerToRuntimeStart branch from 84f674a to ae21503 Compare September 6, 2018 07:50
@sleshchenko sleshchenko merged commit 1efaf48 into eclipse-che:master Sep 6, 2018
@sleshchenko sleshchenko deleted the movePluginBrokerToRuntimeStart branch September 6, 2018 07:52
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Sep 6, 2018
@benoitf benoitf added this to the 6.11.0 milestone Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/task Internal things, technical debt, and to-do tasks to be performed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants