Conversation
benoitf
reviewed
Sep 5, 2018
benoitf
added
status/code-review
benoitf
reviewed
Sep 5, 2018
dockerfiles/theia/src/setup.sh
Outdated
| set -e | ||
| set -u | ||
|
|
||
| yum install -y sudo |
Contributor
There was a problem hiding this comment.
if possible, merge it with other yum install instruction post github-check
Contributor
Author
There was a problem hiding this comment.
To me it is clearer when we install components in its logical group/place.
Just curious, what is advantage of such merging?
Contributor
There was a problem hiding this comment.
speed of build (like searching for mirrors again)
Contributor
|
ci-build |
Contributor
|
@mmorhun could you rebase changes to check the e2e tests are passing ? |
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
AndrienkoAleksandr
approved these changes
Sep 5, 2018
Contributor
Author
|
@benoitf done |
ghost
approved these changes
Sep 5, 2018
Contributor
|
ci-build |
benoitf
approved these changes
Sep 5, 2018
benoitf
approved these changes
Sep 5, 2018
Contributor
benoitf
left a comment
benoitf
left a comment
There was a problem hiding this comment.
Please squash the commits
benoitf
removed
the
status/code-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mykola Morhun mmorhun@redhat.com
What does this PR do?
Before we used root in Theia image. It is not good way to go and moreover caused some problems, for example, with
yogenerator.This PR adds regular user
theiaand runs Theia IDE on behalf of the user.What issues does this PR fix or reference?
#10756
Tested on docker infrastructure and openshift.io