Add functional test for checking factory with skipFirstLevel parameter#11104
Merged
musienko-maxim merged 14 commits intomasterfrom Sep 11, 2018
Merged
Add functional test for checking factory with skipFirstLevel parameter#11104musienko-maxim merged 14 commits intomasterfrom
musienko-maxim merged 14 commits intomasterfrom
Conversation
musienko-maxim
requested review from
Ohrimenko1988 and
dmytro-ndp
as code owners
musienko-maxim
changed the title
benoitf
added
status/code-review
Signed-off-by: musienko maksym <mmusiien@redhat.com>
musienko-maxim
force-pushed
the
CHE#11081
branch
from
e55e1f9 to
a124698
Compare
Ohrimenko1988
approved these changes
Sep 7, 2018
SkorikSergey
approved these changes
Sep 7, 2018
dmytro-ndp
reviewed
Sep 10, 2018
|
|
||
| @BeforeClass | ||
| public void setUp() throws Exception { | ||
| testUserPreferencesServiceClient.addGitCommitter(gitHubUsername, productUser.getEmail()); |
Contributor
There was a problem hiding this comment.
It's quite hard to understand what this method is doing without comments and indents. Could you, please, add some explanation into the code?
dmytro-ndp
reviewed
Sep 10, 2018
| public void setUp() throws Exception { | ||
| testUserPreferencesServiceClient.addGitCommitter(gitHubUsername, productUser.getEmail()); | ||
| Path entryPath = | ||
| Paths.get(getClass().getResource("/projects/default-spring-project").getPath()); |
Contributor
There was a problem hiding this comment.
Do we really need to add "default-spring-project" project into the test repository if we then adding into the factory template link to github project archive?
Contributor
Author
There was a problem hiding this comment.
Actually we need.
After adding the test repo - we have URLs like:
- SSH:
git@github.com:gthub_user_name/name_repo - HTTPS:
https://github.com/com:gthub_user_name/name_repo - ZIP:
https://gthub_user_name/name_repo/archive/branch_name.zip
So we use # 3 for the test
Contributor
There was a problem hiding this comment.
In that case, IMHO, testRepo.addContent(entryPath) looks redundant.
musienko-maxim
force-pushed
the
CHE#11081
branch
from
c5243ce to
034d0b1
Compare
musienko-maxim
force-pushed
the
CHE#11081
branch
from
8ec979f to
a8f4d37
Compare
dmytro-ndp
reviewed
Sep 10, 2018
...he-selenium-test/src/test/java/org/eclipse/che/selenium/factory/CheckSkipRootFolderTest.java
Outdated
Show resolved
Hide resolved
Contributor
|
|
dmytro-ndp
approved these changes
Sep 10, 2018
Contributor
Author
|
ci-build |
benoitf
removed
the
status/code-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add checking the
skipFirstLevelparameter in the factory by next scenario:skipFirstLevelparameter.What issues does this PR fix or reference?
#11081
@SkorikSergey, @dmytro-ndp, @Ohrimenko1988