Skip to content

Add heap options env variable to jdt.ls start script#11116

Merged
tsmaeder merged 1 commit intoeclipse-che:5730_java_ls_pocfrom
tsmaeder:11044_jdtls_heap_options
Sep 10, 2018
Merged

Add heap options env variable to jdt.ls start script#11116
tsmaeder merged 1 commit intoeclipse-che:5730_java_ls_pocfrom
tsmaeder:11044_jdtls_heap_options

Conversation

@tsmaeder
Copy link
Copy Markdown
Contributor

@tsmaeder tsmaeder commented Sep 7, 2018

What does this PR do?

Adds support for passing in the env variable CHE_WORKSPACE_JDT_LS_HEAP_OPTIONS to replace the default heap options used in the jdt.ls installer generated launch script. Default it "-Xmx1024M".
We might consider adding more env variables in the future.

What issues does this PR fix or reference?

#11044

Signed-off-by: Thomas Mäder <tmader@redhat.com>
@tsmaeder tsmaeder added kind/enhancement A feature request - must adhere to the feature request template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. target/branch Indicates that a PR will be merged into a branch other than master. team/languages labels Sep 7, 2018
@tsmaeder tsmaeder requested a review from tolusha September 7, 2018 12:37
@tsmaeder tsmaeder merged commit 79ed65a into eclipse-che:5730_java_ls_poc Sep 10, 2018
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Sep 10, 2018
tsmaeder added a commit that referenced this pull request Sep 13, 2018
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder added a commit that referenced this pull request Sep 20, 2018
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder added a commit that referenced this pull request Sep 26, 2018
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder added a commit that referenced this pull request Oct 1, 2018
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder added a commit that referenced this pull request Oct 5, 2018
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder added a commit that referenced this pull request Oct 12, 2018
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder added a commit that referenced this pull request Oct 16, 2018
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder added a commit that referenced this pull request Oct 17, 2018
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder added a commit that referenced this pull request Oct 17, 2018
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder added a commit that referenced this pull request Oct 17, 2018
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder added a commit that referenced this pull request Oct 17, 2018
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder added a commit that referenced this pull request Oct 17, 2018
Signed-off-by: Thomas Mäder <tmader@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement A feature request - must adhere to the feature request template. target/branch Indicates that a PR will be merged into a branch other than master.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants