Skip to content

Set JWT proxy pulling strategy to Always#11117

Merged
garagatyi merged 1 commit intoeclipse-che:masterfrom
garagatyi:fixJWTPulling
Sep 7, 2018
Merged

Set JWT proxy pulling strategy to Always#11117
garagatyi merged 1 commit intoeclipse-che:masterfrom
garagatyi:fixJWTPulling

Conversation

@garagatyi
Copy link
Copy Markdown

What does this PR do?

Now JWT Proxy uses image pull policy IfNotPresent which means that updates of a tag of the image are not populated on a node where this tag already exists.
I believe that pulling strategy Always would be a better fit for a security container.

What issues does this PR fix or reference?

Release Notes

Docs PR

Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com>
Copy link
Copy Markdown
Member

@sleshchenko sleshchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks for fixing it 👍

@benoitf benoitf added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Sep 7, 2018
@garagatyi garagatyi merged commit ddf0f32 into eclipse-che:master Sep 7, 2018
@garagatyi garagatyi deleted the fixJWTPulling branch September 7, 2018 14:25
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Sep 7, 2018
@benoitf benoitf added this to the 6.11.0 milestone Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants