Fix an ability to use locally built images of Che on minishift#11118
Merged
garagatyi merged 1 commit intoeclipse-che:masterfrom Sep 7, 2018
Merged
Conversation
Latest versions of minishift ignore Che master docker image that was built locally inside the VM. Removeing docker.io from the image name workarounds the issue. Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com>
garagatyi
requested review from
l0rd,
riuvshin and
sleshchenko
as code owners
benoitf
added
status/code-review
ghost
approved these changes
Sep 7, 2018
benoitf
removed
the
status/code-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Latest versions of minishift ignore Che master docker image that
was built locally inside the VM.
Removing
docker.ioprefix from the image name workarounds the issue.What issues does this PR fix or reference?
Release Notes
Docs PR