Fix selenium tests in 'git' package to increase reliability#11125
Merged
dmytro-ndp merged 3 commits intomasterfrom Sep 8, 2018
Merged
Fix selenium tests in 'git' package to increase reliability#11125dmytro-ndp merged 3 commits intomasterfrom
dmytro-ndp merged 3 commits intomasterfrom
Conversation
artaleks9
added
status/code-review
artaleks9
requested review from
Ohrimenko1988 and
musienko-maxim
as code owners
SkorikSergey
approved these changes
Sep 7, 2018
dmytro-ndp
reviewed
Sep 7, 2018
| git.closeGitInfoPanel(); | ||
| projectExplorer.selectMultiFilesByCtrlKeys( | ||
| PROJECT_NAME + "/my-webapp/src/main/java/helloworld/AppController.java"); | ||
| menu.runCommand(TestMenuCommandsConstants.Git.GIT, TestMenuCommandsConstants.Git.ADD_TO_INDEX); |
Contributor
There was a problem hiding this comment.
Does it really work without adding changes to index?
Contributor
Author
There was a problem hiding this comment.
Yes, of course. We can commit changes without add to index from UI Git command
Contributor
There was a problem hiding this comment.
That is the changes are added to index automatically.
artaleks9
changed the title
dmytro-ndp
reviewed
Sep 7, 2018
|
|
||
| @Test | ||
| public void checkAmendPreviousCommit() { | ||
| String pathToFile = PROJECT_NAME + "/src/main/java/org.eclipse.qa.examples"; |
Contributor
There was a problem hiding this comment.
We have already have PATH_TO_FILE constant which looks similar to pathToFile. I would name variable differently to avoid confusion.
Contributor
There was a problem hiding this comment.
What about the name pathToFileItem?
dmytro-ndp
approved these changes
Sep 8, 2018
benoitf
removed
the
status/code-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What issues does this PR fix or reference?
#11105