Skip to content

Manage the list of plugins from Che plugins registry#11143

Merged
ashumilova merged 1 commit intomasterfrom
plugins_list
Sep 13, 2018
Merged

Manage the list of plugins from Che plugins registry#11143
ashumilova merged 1 commit intomasterfrom
plugins_list

Conversation

@ashumilova
Copy link
Copy Markdown
Contributor

Signed-off-by: Anna Shumilova ashumilo@redhat.com

What does this PR do?

Brings ability for the user to select Che plugins on workspace details page on "Plugins" tab.

What issues does this PR fix or reference?

#10780

@ashumilova
Copy link
Copy Markdown
Contributor Author

ci-test

@benoitf benoitf added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Sep 10, 2018
Copy link
Copy Markdown
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A screenshot of UI would be nice in PR's description

@ashumilova
Copy link
Copy Markdown
Contributor Author

Adding a screenshot:
screenshot from 2018-09-10 17-21-22

@ashumilova ashumilova requested a review from slemeur September 10, 2018 14:22
@riuvshin
Copy link
Copy Markdown
Contributor

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:11143
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@slemeur
Copy link
Copy Markdown
Contributor

slemeur commented Sep 10, 2018

How does this work?

Is this tab displayed for all workspaces, or only the ones with Theia?
Could/Should we remove the "Installers" tab if the "Plugins" tab is there?

Otherwise the table is efficient and good.
Maybe instead of "Use" I would say "Enable".

Question (not a priority right now):
Is this list sorted? Can I filter by the one enabled/disabled?

@ashumilova
Copy link
Copy Markdown
Contributor Author

@slemeur

  1. the Plugins tab is displayed, when Che settings have the plugin registry location property set. It's displayed for all workspaces, cause it gives an opportunity to enable IDE ("theia-ide" on screenshot), so in general should not depend on the workspace's machine definition.
  2. yes, we can hide installers, when plugins are there - perhaps QE will have to adapt the tests
  3. can easily change "Use" to "Enabled"
  4. sorting by enabled - perhaps will bring to "dancing" items -> I will enable the last and it will go to the top.
  5. filtering works by name

Signed-off-by: Anna Shumilova <ashumilo@redhat.com>
@ashumilova ashumilova merged commit d63304e into master Sep 13, 2018
@ashumilova ashumilova deleted the plugins_list branch September 13, 2018 06:56
@garagatyi
Copy link
Copy Markdown

Cool!

@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Sep 18, 2018
@benoitf benoitf added this to the 6.12.0 milestone Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants