Add actual values of web element in SeleniumWebDriver error message#11153
Merged
dmytro-ndp merged 1 commit intomasterfrom Sep 11, 2018
Merged
Add actual values of web element in SeleniumWebDriver error message#11153dmytro-ndp merged 1 commit intomasterfrom
dmytro-ndp merged 1 commit intomasterfrom
Conversation
Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>
Contributor
Author
|
ci-test |
Contributor
|
ci-test build report: |
Contributor
Author
|
ci-test-docker-single |
Contributor
|
ci-test build report: |
Ohrimenko1988
approved these changes
Sep 11, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It adds actual values into error messages which are produced by those methods of
SeleniumWebDriverHelperclass which are waiting on certain text of web element.To have correct error messages we need to stop sharing
WebDriverWaitinstances byWebDriverWaitFactoryclass with the same timeout.Examples of error message:
Many thanks to @tsmaeder for an idea and example of implementation.
What issues does this PR fix or reference?
#11149