Added authorization checks for all factory service's methods#11156
Merged
sleshchenko merged 1 commit intoeclipse-che:masterfrom Sep 11, 2018
Merged
Added authorization checks for all factory service's methods#11156sleshchenko merged 1 commit intoeclipse-che:masterfrom
sleshchenko merged 1 commit intoeclipse-che:masterfrom
Conversation
sleshchenko
added
kind/bug
Member
Author
|
ci-test |
Signed-off-by: Sergii Leshchenko <sleshche@redhat.com>
sleshchenko
force-pushed
the
factoryAuthorization
branch
from
4862791 to
979fbb1
Compare
Contributor
|
ci-test build report: |
skabashnyuk
approved these changes
Sep 11, 2018
ibuziuk
approved these changes
Sep 11, 2018
garagatyi
approved these changes
Sep 11, 2018
benoitf
removed
the
status/code-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Previously it was possible to remove any factory by id. This PR adds authorization checks for all factory service's methods. Public ones are explicitly listed.
What issues does this PR fix or reference?
#11155
Release Notes
N/A
Docs PR
N/A