Rename project attributes column name to avoid reserved keyword#11237
Merged
mshaposhnik merged 2 commits intomasterfrom Sep 18, 2018
Merged
Rename project attributes column name to avoid reserved keyword#11237mshaposhnik merged 2 commits intomasterfrom
mshaposhnik merged 2 commits intomasterfrom
Conversation
skabashnyuk
approved these changes
Sep 17, 2018
| -- Red Hat, Inc. - initial API and implementation | ||
| -- | ||
|
|
||
| ALTER TABLE projectattribute_values RENAME COLUMN values TO attribute_values; |
Contributor
There was a problem hiding this comment.
are you sure it's working H2, PostgreSQL? MySQL?
Contributor
Author
There was a problem hiding this comment.
Yes our integration tests on H2 & Postgres are passed. MySQL only syntax check.
benoitf
added
the
kind/task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Rename project attributes column name to avoid reserved keyword usage.
What issues does this PR fix or reference?
#11192
Release Notes
N/A