Skip to content

Provide basic Apache Camel stack#11245

Merged
benoitf merged 2 commits intoeclipse-che:masterfrom
apupier:11236-IncludeCamelStack
Sep 20, 2018
Merged

Provide basic Apache Camel stack#11245
benoitf merged 2 commits intoeclipse-che:masterfrom
apupier:11236-IncludeCamelStack

Conversation

@apupier
Copy link
Copy Markdown
Contributor

@apupier apupier commented Sep 17, 2018

Signed-off-by: Aurélien Pupier apupier@redhat.com

What does this PR do?

What issues does this PR fix or reference?

Release Notes

Docs PR

@riuvshin
Copy link
Copy Markdown
Contributor

riuvshin commented Sep 17, 2018

Can one of the admins verify this patch?

2 similar comments
@riuvshin
Copy link
Copy Markdown
Contributor

riuvshin commented Sep 17, 2018

Can one of the admins verify this patch?

@riuvshin
Copy link
Copy Markdown
Contributor

riuvshin commented Sep 17, 2018

Can one of the admins verify this patch?

@apupier
Copy link
Copy Markdown
Contributor Author

apupier commented Sep 17, 2018

ci-build

@apupier
Copy link
Copy Markdown
Contributor Author

apupier commented Sep 17, 2018

ci-test

@benoitf
Copy link
Copy Markdown
Contributor

benoitf commented Sep 17, 2018

ci-build

benoitf
benoitf reviewed Sep 17, 2018
View reviewed changes
ide/che-core-ide-stacks/src/main/resources/stacks.json
"mediaType": "image/svg+xml"
}
}
},
Copy link
Copy Markdown
Contributor

@benoitf benoitf Sep 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI tabs need to be replaced by 2 spaces

@apupier apupier force-pushed the 11236-IncludeCamelStack branch 4 times, most recently from 14c103b to c39ae62 Compare September 17, 2018 13:42
@apupier
Copy link
Copy Markdown
Contributor Author

apupier commented Sep 17, 2018

ci-build

@apupier
Copy link
Copy Markdown
Contributor Author

apupier commented Sep 17, 2018

ci-test

@riuvshin
Copy link
Copy Markdown
Contributor

riuvshin commented Sep 17, 2018

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:11245
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@benoitf benoitf added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Sep 18, 2018
@apupier
Provide basic Apache Camel stack (eclipse-che#11236)
828988e 
Signed-off-by: Aurélien Pupier <apupier@redhat.com>
@apupier
Provide test checking Camel LS available with Apache Camel stack
16f9d17 
(eclipse-che#11236)

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
@apupier apupier force-pushed the 11236-IncludeCamelStack branch from c39ae62 to 16f9d17 Compare September 19, 2018 09:10
@apupier
Copy link
Copy Markdown
Contributor Author

apupier commented Sep 19, 2018

ci-test

@riuvshin
Copy link
Copy Markdown
Contributor

riuvshin commented Sep 19, 2018

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:11245
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@apupier
Copy link
Copy Markdown
Contributor Author

apupier commented Sep 19, 2018 •
edited
Loading

Can someone review please?

The PR is adding a new stack for Apache Camel which contains for now:

  • activation of Language Server protocol
  • things to do springboot development (based on the springboot stack)
  • commands to help triggering springboot actions

the test provided is covering:

  • ensure there is a stack and that a workspace can be created with it
  • ensure that the Apache Camel Language Server is well started

it does not cover the commands

@benoitf
Copy link
Copy Markdown
Contributor

benoitf commented Sep 19, 2018

@musienko-maxim ?

@benoitf benoitf merged commit 04b2f5a into eclipse-che:master Sep 20, 2018
@benoitf benoitf added this to the 6.12.0 milestone Sep 20, 2018
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benoitf benoitf benoitf approved these changes

@musienko-maxim musienko-maxim musienko-maxim approved these changes

@dmytro-ndp dmytro-ndp Awaiting requested review from dmytro-ndp

@Ohrimenko1988 Ohrimenko1988 Awaiting requested review from Ohrimenko1988

+1 more reviewer

@ashumilova ashumilova ashumilova approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

6.12.0

Development

Successfully merging this pull request may close these issues.

5 participants

@apupier @riuvshin @benoitf @ashumilova @musienko-maxim