Add selenium tests for covering advanced operations for C# LS by musienko-maxim · Pull Request #11261 · eclipse-che/che

musienko-maxim · 2018-09-18T13:23:18Z

What does this PR do?

Add new 4 tests for checking uncovered features like: hovering, autocommenting, find definition, go to symbol.

What issues does this PR fix or reference?

Ohrimenko1988 · 2018-09-18T13:33:07Z

...st/java/org/eclipse/che/selenium/languageserver/csharp/CSharpFileAdvancedOperationsTest.java

+  private static final String PROJECT_NAME =
+      NameGenerator.generate(CSharpClassRenamingTest.class.getSimpleName(), 4);
+
+  private static final String PATH_TO_DOTNET_FILE = PROJECT_NAME + "/Hello.cs";


What about "PATH_TO_DOTNET_FILE" >>> "PATH_TO_DOT_NET_FILE"

Ohrimenko1988 · 2018-09-18T13:36:47Z

...st/java/org/eclipse/che/selenium/languageserver/csharp/CSharpFileAdvancedOperationsTest.java

+    String expectedTextInHoverPopUp =
+        "System.Console\nRepresents the standard input, output, and error streams for console applications. This class cannot be inherited.";
+    editor.moveCursorToText("Console");
+    Assert.assertEquals(editor.getTextFromHoverPopup(), expectedTextInHoverPopUp, "https://github.com/eclipse/che/issues/10117");


Better change to "editor.waitTextInHoverPopup(expectedTextInHoverPopUp);" this increase stability of this test

waitTextInHoverPopup does not work in this case because use this: seleniumWebDriverHelper.waitTextContains(hoverPopup, expectedText);. In this case check full text matching because text is duplicated.
Moreover editor.getTextFromHoverPopup() already had visibility waiting and pretty stable as for me

In that case we could make both editor.waitTextInHoverPopupEqualsTo(expectedText) and editor.waitTextInHoverPopupContains(expectedText)

Ok, I understand, but you definitely will have a problem with this assert because it tries to get text exactly once and if something doesn't display, test will be failed.
What about adding a new method to page object with "SeleniumWebDriverHelper#waitTextEqualsTo"

Ohrimenko1988 · 2018-09-18T13:38:20Z

...st/java/org/eclipse/che/selenium/languageserver/csharp/CSharpFileAdvancedOperationsTest.java

+  public void checkFindDefinition() {
+    editor.goToCursorPositionVisible(21, 18);
+    menu.runCommand(ASSISTANT, FIND_DEFINITION);
+    editor.waitTabFileWithSavedStatus("Test.cs");


Did you mean "editor.waitTabIsPresent("Test.cs");"?

SkorikSergey · 2018-09-18T13:46:03Z

...st/java/org/eclipse/che/selenium/languageserver/csharp/CSharpFileAdvancedOperationsTest.java

+
+  @Test(priority = 3, alwaysRun = true)
+  public void checkGoToSymbolFeature() {
+    menu.runCommand(ASSISTANT, FIND_DEFINITION);


menu.runCommand(ASSISTANT, FIND_DEFINITION); -> menu.runCommand(ASSISTANT, GO_TO_SYMBOL);

...st/java/org/eclipse/che/selenium/languageserver/csharp/CSharpFileAdvancedOperationsTest.java

Ohrimenko1988 · 2018-09-18T13:56:10Z

...st/java/org/eclipse/che/selenium/languageserver/csharp/CSharpFileAdvancedOperationsTest.java

+  @Test(priority = 2, alwaysRun = true)
+  public void checkCodeCommentFeature() {
+    editor.goToPosition(17, 1);
+    editor.typeTextIntoEditor(CONTROL.toString() + "/");


As I know it doesn't work. Please change to:

String comment = Keys.chord(CONTROL, "/"); seleniumWebDriverHelper.sendKeys(comment);

Doesn't work where? More details please.

Did you test this? If it works then OK.

Yes it works in my case in grid and local mode

I would recommend to use existed method CodenvyEditor#launchCommentCodeFeature() to comment the line.

dmytro-ndp · 2018-09-18T14:03:23Z

...st/java/org/eclipse/che/selenium/languageserver/csharp/CSharpFileAdvancedOperationsTest.java

+    String expectedTextInHoverPopUp =
+        "System.Console\nRepresents the standard input, output, and error streams for console applications. This class cannot be inherited.";
+    editor.moveCursorToText("Console");
+    Assert.assertEquals(editor.getTextFromHoverPopup(), expectedTextInHoverPopUp, "https://github.com/eclipse/che/issues/10117");


Also I would make error message clearer, like the follow:

Known random failure https://github.com/eclipse/che/issues/10117

dmytro-ndp · 2018-09-18T14:05:35Z

...st/java/org/eclipse/che/selenium/languageserver/csharp/CSharpFileAdvancedOperationsTest.java

+
+  @Test(priority = 1, alwaysRun = true)
+  public void checkFindDefinition() {
+    editor.goToCursorPositionVisible(21, 18);


Could you, please, comment, which which thing we are trying to find definition of here?

SkorikSergey · 2018-09-19T07:05:30Z

selenium/che-selenium-test/src/main/java/org/eclipse/che/selenium/pageobject/CodenvyEditor.java

    return seleniumWebDriverHelper.waitVisibilityAndGetText(hoverPopup);
  }

+  /** Get text from hover popup */


/** Get text from hover popup / --> /* Wait text from hover popup*/

…To(String expectedText)' method

dmytro-ndp · 2018-09-18T14:07:33Z

...st/java/org/eclipse/che/selenium/languageserver/csharp/CSharpFileAdvancedOperationsTest.java

+
+  @BeforeClass
+  public void setUp() throws Exception {
+    URL resource = getClass().getResource("/projects/CSharpFileAdvancedOperations");


Could you, please, comment on what we are trying to achieve here?

In my opinion, just renaming of variable to something like "testProject" will be enough.

I meant setUp() method itself - what it is actually setting up?

For example the same: https://github.com/eclipse/che/blob/master/selenium/che-selenium-test/src/test/java/org/eclipse/che/selenium/debugger/PhpProjectDebuggingTest.java#L75
What are we setting up here?

Well, I am talking about state of IDE which we are achieving after the method is executed.
According to the code, I would write that the method "is opening PATH_TO_DOTNET_FILE, then waits initialization of Language Server, and then waits until "/obj" and "/bin" directories are visible in ProjectExplorer".

Ah, i have understood now. So i've added comment, check it please

dmytro-ndp · 2018-09-18T14:10:18Z

...st/java/org/eclipse/che/selenium/languageserver/csharp/CSharpFileAdvancedOperationsTest.java

+    String expectedTextInHoverPopUp =
+        "System.Console\nRepresents the standard input, output, and error streams for console applications. This class cannot be inherited.";
+    editor.moveCursorToText("Console");
+    Assert.assertEquals(editor.getTextFromHoverPopup(), expectedTextInHoverPopUp, "https://github.com/eclipse/che/issues/10117");


In that case we could make both editor.waitTextInHoverPopupEqualsTo(expectedText) and editor.waitTextInHoverPopupContains(expectedText)

dmytro-ndp · 2018-09-19T09:47:22Z

selenium/che-selenium-test/src/main/java/org/eclipse/che/selenium/pageobject/CodenvyEditor.java

+      seleniumWebDriverHelper.waitTextEqualsTo(hoverPopup, expectedText);
+    } catch (TimeoutException ex) {
+      // remove try-catch block after issue has been resolved
+      fail("Known issue https://github.com/eclipse/che/issues/10117", ex);


Do you happen to know if it is permanent or random failure?

musienko-maxim · 2018-09-20T07:21:31Z

ci-build

musienko-maxim · 2018-09-20T08:28:22Z

ci-build

musienko-maxim added 3 commits September 18, 2018 15:45

add test for covering advanced C# language server features

5bafc14

Merge branch 'master' into CHE#11202

abd1702

Add known issue tщ the test

628d1b3

musienko-maxim requested review from Ohrimenko1988 and dmytro-ndp as code owners September 18, 2018 13:23

musienko-maxim added 3 commits September 18, 2018 16:25

add empty line to sample file

6bc0513

add empty line to conf file

a7d39c9

Update Test.cs

bf75ef6

musienko-maxim requested a review from SkorikSergey September 18, 2018 13:26

musienko-maxim changed the title ~~Add selenium tests for covering advanced operations~~ Add selenium tests for covering advanced operations for C# LS Sep 18, 2018

Ohrimenko1988 reviewed Sep 18, 2018

View reviewed changes

SkorikSergey reviewed Sep 18, 2018

View reviewed changes

...st/java/org/eclipse/che/selenium/languageserver/csharp/CSharpFileAdvancedOperationsTest.java Show resolved Hide resolved

Ohrimenko1988 reviewed Sep 18, 2018

View reviewed changes

dmytro-ndp reviewed Sep 18, 2018

View reviewed changes

benoitf added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. labels Sep 18, 2018

Ohrimenko1988 approved these changes Sep 18, 2018

View reviewed changes

musienko-maxim added 3 commits September 18, 2018 17:24

apply proposals to the PR

5ff121a

Merge branch 'CHE#11202' of github.com:eclipse/che into CHE#11202

c0c8a8e

fix signature of methods

fd88c54

SkorikSergey reviewed Sep 19, 2018

View reviewed changes

change java dock

d5e3b40

musienko-maxim force-pushed the CHE#11202 branch from 716647b to d5e3b40 Compare September 19, 2018 07:32

musienko-maxim and others added 2 commits September 19, 2018 10:36

resolve conflicts

8115333

Add one more known issue to 'CodenvyEditor#waitTextInHoverPopUpEquals…

279453b

…To(String expectedText)' method

dmytro-ndp reviewed Sep 19, 2018

View reviewed changes

Ohrimenko1988 mentioned this pull request Sep 19, 2018

[ Selenium ] Update usecases in "PhpAssistantFeaturesTest" for catching known bugs #10117 #10698 #11283

Merged

musienko-maxim force-pushed the CHE#11202 branch 2 times, most recently from ab54127 to 279453b Compare September 19, 2018 13:59

add propositions to PR

a3e70d7

dmytro-ndp approved these changes Sep 19, 2018

View reviewed changes

SkorikSergey approved these changes Sep 19, 2018

View reviewed changes

musienko-maxim added 2 commits September 20, 2018 10:15

add test method for checking find reference feature

5f5c4e1

add usecase to testsuite

bf9f965

apply correct formatter

b1f958b

musienko-maxim merged commit b5ceb99 into master Sep 20, 2018

benoitf added this to the 6.12.0 milestone Sep 20, 2018

benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Sep 20, 2018

musienko-maxim deleted the CHE#11202 branch September 20, 2018 12:30

Conversation

musienko-maxim commented Sep 18, 2018

What does this PR do?

What issues does this PR fix or reference?

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

musienko-maxim Sep 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Ohrimenko1988 Sep 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

musienko-maxim Sep 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

musienko-maxim Sep 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dmytro-ndp Sep 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

musienko-maxim commented Sep 20, 2018

Uh oh!

musienko-maxim commented Sep 20, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

musienko-maxim Sep 18, 2018 •

edited

Loading

Ohrimenko1988 Sep 18, 2018 •

edited

Loading

musienko-maxim Sep 18, 2018 •

edited

Loading

musienko-maxim Sep 19, 2018 •

edited

Loading

dmytro-ndp Sep 19, 2018 •

edited

Loading