Skip to content

6.11.1#11292

Merged
ibuziuk merged 2 commits intoeclipse-che:6.11.xfrom
amisevsk:6.11.1
Sep 20, 2018
Merged

6.11.1#11292
ibuziuk merged 2 commits intoeclipse-che:6.11.xfrom
amisevsk:6.11.1

Conversation

@amisevsk
Copy link
Copy Markdown
Contributor

@amisevsk amisevsk commented Sep 20, 2018

mshaposhnik and others added 2 commits September 20, 2018 09:16
@mshaposhnik @amisevsk
Add extra workspace existence check before creating keypair
5c06ba6
@amisevsk
Fix k8s/OS deployment cleanup when pod failed to start
682df13 
The move to Deployments introduced a regression where the delete
workspace methods assume that a pod had been started as some point. If,
e.g. the workspace config refers to an invalid service account, a
deployment will be created, but no pod will ever start, causing the
delete method to fail to clean up the deployment. This means that
workspace cannot be started, even if the error in config is fixed.

Fixes this issue, by splitting the delete flow in KubernetesDeployments.

Signed-off-by: Angel Misevski <amisevsk@redhat.com>
@amisevsk
Copy link
Copy Markdown
Contributor Author

amisevsk commented Sep 20, 2018

ci-test

@benoitf benoitf added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. target/branch Indicates that a PR will be merged into a branch other than master. labels Sep 20, 2018
@riuvshin
Copy link
Copy Markdown
Contributor

riuvshin commented Sep 20, 2018

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:11292
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@ibuziuk
Copy link
Copy Markdown
Member

ibuziuk commented Sep 20, 2018

ci-test

@riuvshin
Copy link
Copy Markdown
Contributor

riuvshin commented Sep 20, 2018

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:11292
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@ibuziuk
Copy link
Copy Markdown
Member

ibuziuk commented Sep 20, 2018

@riuvshin looks like there is a problem with parent pom

16:33:21 [ERROR] [ERROR] Some problems were encountered while processing the POMs:
16:33:21 [FATAL] Non-resolvable parent POM for org.eclipse.che:che-parent:6.11.1-SNAPSHOT: Failure to find org.eclipse.che.depmgt:maven-depmgt-pom:pom:6.11.1-SNAPSHOT in https://oss.sonatype.org/content/repositories/snapshots/ was cached in the local repository, resolution will not be reattempted until the update interval of ossrh has elapsed or updates are forced and 'parent.relativePath' points at wrong local POM @ line 17, column 13

how should we proceed with it ?

@riuvshin
Copy link
Copy Markdown
Contributor

riuvshin commented Sep 20, 2018 •
edited
Loading

@ibuziuk you should submit PR against master, if it goes well then I will backport it to bugfix branch

@ibuziuk
Copy link
Copy Markdown
Member

ibuziuk commented Sep 20, 2018

@riuvshin but PRs are already merged in master:

@amisevsk
Copy link
Copy Markdown
Contributor Author

amisevsk commented Sep 20, 2018

A plain mvn clean install works locally for me.

@riuvshin
Copy link
Copy Markdown
Contributor

riuvshin commented Sep 20, 2018

@amisevsk that's because you have it cached in local maven repo.
@ibuziuk ah, if PRs are in master already we usually just cherry-pick them and release

@ibuziuk ibuziuk self-requested a review September 20, 2018 14:51
@ibuziuk ibuziuk merged commit e9070b8 into eclipse-che:6.11.x Sep 20, 2018
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Sep 20, 2018
@ibuziuk ibuziuk mentioned this pull request Sep 20, 2018
Closed
@amisevsk amisevsk mentioned this pull request Sep 20, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ibuziuk ibuziuk ibuziuk approved these changes

@mshaposhnik mshaposhnik mshaposhnik approved these changes

@garagatyi garagatyi Awaiting requested review from garagatyi

@sleshchenko sleshchenko Awaiting requested review from sleshchenko

+1 more reviewer

@riuvshin riuvshin riuvshin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

target/branch Indicates that a PR will be merged into a branch other than master.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@amisevsk @riuvshin @ibuziuk @mshaposhnik @benoitf