Wait for loader to close after jdt.ls workspace updated message.#11294
Merged
tsmaeder merged 1 commit intoeclipse-che:5730_java_ls_pocfrom Sep 20, 2018
Merged
Conversation
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder
requested review from
Ohrimenko1988,
dmytro-ndp and
musienko-maxim
as code owners
benoitf
added
the
target/branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Introduces a loader.waitForClosed() after getting the "workspace udpated" message from jdt.ls. The background is that the project explorer is updating at this time and if we do an expand of the tree, the tree may be collapsed again because it changes.
This PR servers to test the hypothesis that this is leadiung to various ci-test failures.