CHE-10883 migrate from bower to yarn by olexii4 · Pull Request #11301 · eclipse-che/che

olexii4 · 2018-09-21T07:56:16Z

Signed-off-by: Oleksii Orel oorel@redhat.com

What does this PR do?

Migrate from bower to yarn.

What issues does this PR fix or reference?

#10881
#10883

dashboard/Dockerfile

ashumilova · 2018-09-21T11:31:26Z

ci-test

olexii4 · 2018-09-23T17:45:03Z

ci-test

riuvshin · 2018-09-23T21:04:34Z

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:11301
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

olexii4 · 2018-09-24T09:59:36Z

ci-test

riuvshin · 2018-09-24T13:27:54Z

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:11301
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

olexii4 · 2018-09-24T15:32:16Z

ci-test

riuvshin · 2018-09-24T18:58:53Z

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:11301
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

olexii4 · 2018-09-25T09:58:18Z

ci-test

riuvshin · 2018-09-25T10:18:13Z

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:11301
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

olexii4 · 2018-09-25T11:52:12Z

ci-test

riuvshin · 2018-09-25T15:19:09Z

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:11301
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

musienko-maxim · 2018-09-26T07:41:52Z

The functional parts work as well. But we have broken icons and dependent images on dashboard. See screenshots below:

musienko-maxim

We should fix images and icons

olexii4 · 2018-09-26T09:41:19Z

ci-test

riuvshin · 2018-09-26T12:42:12Z

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:11301
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

olexii4 · 2018-09-26T17:02:24Z

ci-test

olexii4 · 2018-09-27T22:00:28Z

ci-test

riuvshin · 2018-09-28T02:14:26Z

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:11301
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

olexii4 · 2018-10-01T01:44:41Z

ci-test

riuvshin · 2018-10-01T04:43:51Z

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:11301
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

SkorikSergey · 2018-10-01T09:53:58Z

Selenium tests execution on Eclipse Che Multiuser on OCP (https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/894/) doesn't show any regression against this Pull Request.

benoitf · 2018-10-01T13:27:39Z

dashboard/src/index.ts

+ * Contributors:
+ *   Red Hat, Inc. - initial API and implementation
+ */
+export interface ICheWindow extends Window{


missing space after Window

nickboldt · 2018-10-03T13:47:52Z

Will this change be included in 6.12.0 release?

nickboldt · 2018-10-03T13:51:50Z

Also I just noticed this moves us from node 6.11.2 -> 8.10.0.

Will a similar change also happen for the node project in https://github.com/eclipse/che-lib/tree/master/che-terminal-client ? It would be good to be able to build all of Che with the same pod definition (all with the same version of npm/node/mvn/java/golang).

olexii4 · 2018-10-03T14:51:34Z

@AndrienkoAleksandr WDYT?

AndrienkoAleksandr · 2018-10-03T14:55:40Z

@nickboldt for build xterm.js we don't use docker.

nickboldt · 2018-10-03T18:12:16Z

@nickboldt for build xterm.js we don't use docker.

I'm not talking about docker - I asked about node 6 -> 8. You definitely use npm:

https://github.com/eclipse/che-lib/blob/master/che-terminal-client/pom.xml#L88

AndrienkoAleksandr · 2018-10-04T07:36:02Z

@nickboldt I do full rebuild Eclipse CHE quite often. And On the my laptop I set up node 8.9.1. So I do build xterm.js (in the che-lib) with this version and everithing is ok.

Signed-off-by: Oleksii Orel <oorel@redhat.com>

olexii4 · 2018-10-04T09:22:28Z

ci-test

riuvshin · 2018-10-04T12:06:12Z

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:11301
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

olexii4 requested review from ashumilova and benoitf as code owners September 21, 2018 07:56

olexii4 requested a review from akurinnoy September 21, 2018 07:56

benoitf added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. labels Sep 21, 2018

benoitf reviewed Sep 21, 2018

View reviewed changes

dashboard/Dockerfile Outdated Show resolved Hide resolved

olexii4 force-pushed the CHE-10883 branch from 2f88027 to b92f6cf Compare September 23, 2018 17:44

vkuznyetsov mentioned this pull request Sep 24, 2018

QE-2018-10-02 (Sprint: 155) #10992

Closed

47 tasks

olexii4 force-pushed the CHE-10883 branch from bac6fe8 to 61f9161 Compare September 24, 2018 15:29

olexii4 force-pushed the CHE-10883 branch from 98733d3 to f23e3fb Compare September 25, 2018 11:51

ashumilova mentioned this pull request Sep 25, 2018

IDE2-2018-10-23 (Sprint: 156) #11345

Closed

33 tasks

olexii4 requested a review from musienko-maxim September 25, 2018 15:22

musienko-maxim approved these changes Sep 25, 2018

View reviewed changes

musienko-maxim requested changes Sep 26, 2018

View reviewed changes

olexii4 force-pushed the CHE-10883 branch from afd0108 to 1939906 Compare September 26, 2018 16:56

olexii4 force-pushed the CHE-10883 branch from 2f4578b to c08de50 Compare September 27, 2018 21:59

olexii4 force-pushed the CHE-10883 branch 2 times, most recently from 71a8d9a to 5f1a247 Compare October 1, 2018 01:43

olexii4 changed the title ~~[WIP] CHE-10883 migrate from bower to yarn~~ CHE-10883 migrate from bower to yarn Oct 1, 2018

musienko-maxim approved these changes Oct 1, 2018

View reviewed changes

benoitf approved these changes Oct 1, 2018

View reviewed changes

benoitf reviewed Oct 1, 2018

View reviewed changes

akurinnoy approved these changes Oct 3, 2018

View reviewed changes

CHE-10883 migrate from bower to yarn

d27a638

Signed-off-by: Oleksii Orel <oorel@redhat.com>

olexii4 force-pushed the CHE-10883 branch from 5f1a247 to d27a638 Compare October 4, 2018 09:22

SkorikSergey approved these changes Oct 4, 2018

View reviewed changes

ashumilova removed their request for review October 4, 2018 13:16

olexii4 merged commit 29818c2 into master Oct 4, 2018

olexii4 deleted the CHE-10883 branch October 4, 2018 13:17

benoitf added this to the 6.12.0 milestone Oct 4, 2018

benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Oct 4, 2018

garagatyi mentioned this pull request Oct 9, 2018

Fix Che dashboard build redhat-developer/rh-che#958

Closed

5 tasks

Conversation

olexii4 commented Sep 21, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

What issues does this PR fix or reference?

Uh oh!

Uh oh!

ashumilova commented Sep 21, 2018

Uh oh!

olexii4 commented Sep 23, 2018

Uh oh!

riuvshin commented Sep 23, 2018

Uh oh!

olexii4 commented Sep 24, 2018

Uh oh!

riuvshin commented Sep 24, 2018

Uh oh!

olexii4 commented Sep 24, 2018

Uh oh!

riuvshin commented Sep 24, 2018

Uh oh!

olexii4 commented Sep 25, 2018

Uh oh!

riuvshin commented Sep 25, 2018

Uh oh!

olexii4 commented Sep 25, 2018

Uh oh!

riuvshin commented Sep 25, 2018

Uh oh!

musienko-maxim commented Sep 26, 2018

Uh oh!

musienko-maxim left a comment

Choose a reason for hiding this comment

Uh oh!

olexii4 commented Sep 26, 2018

Uh oh!

riuvshin commented Sep 26, 2018

Uh oh!

olexii4 commented Sep 26, 2018

Uh oh!

olexii4 commented Sep 27, 2018

Uh oh!

riuvshin commented Sep 28, 2018

Uh oh!

olexii4 commented Oct 1, 2018

Uh oh!

riuvshin commented Oct 1, 2018

Uh oh!

SkorikSergey commented Oct 1, 2018

Uh oh!

benoitf Oct 1, 2018

Choose a reason for hiding this comment

Uh oh!

nickboldt commented Oct 3, 2018

Uh oh!

nickboldt commented Oct 3, 2018

Uh oh!

olexii4 commented Oct 3, 2018

Uh oh!

AndrienkoAleksandr commented Oct 3, 2018

Uh oh!

nickboldt commented Oct 3, 2018

Uh oh!

AndrienkoAleksandr commented Oct 4, 2018

Uh oh!

olexii4 commented Oct 4, 2018

Uh oh!

riuvshin commented Oct 4, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

olexii4 commented Sep 21, 2018 •

edited

Loading