Conversation
artaleks9
added
status/code-review
| } | ||
|
|
||
| public void doubleClickOnReference(String visibleText) { | ||
| Actions action = actionsFactory.createAction(seleniumWebDriver); |
There was a problem hiding this comment.
seleniumWebDriverHelper.getAction()
There was a problem hiding this comment.
even more. You can remove this row and replace the last row of the method ( action.doubleClick().perform(); ) by:
seleniumWebDriverHelper.doubleClick();
|
ci-test |
|
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
|
ci-test |
|
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
|
ci-test |
|
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
| seleniumWebDriverHelper.waitTextContains(proposalDoc, expectedText); | ||
| } | ||
|
|
||
| /** enter the 'Ctrl + F12' */ |
There was a problem hiding this comment.
All of key pressing methods look redundant inside CodenvyEditor class, IMHO.
There was a problem hiding this comment.
You mean, that may skip the comment line?
There was a problem hiding this comment.
I meant that we can use seleniumWebDriverHelper.press... methods directly.
| clickOnReference(visibleText); | ||
| waitReferenceSelection(visibleText); | ||
| action.doubleClick().perform(); | ||
| seleniumWebDriverHelper.doubleClick(); |
| private static final String REFERENCES_NOTJHING_TO_SHOW_TEXT = "Nothing to show"; | ||
|
|
||
| private static final String[] REFERENCES_EXPECTED_TEXT = { | ||
| "/desktop-go-simple/towers.go\n" + "From:19:5 To:19:10", |
There was a problem hiding this comment.
Concatenation at the middle of row looks weird.
There was a problem hiding this comment.
You propose next:
"/desktop-go-simple/towers.go\nFrom:19:5 To:19:10"
| editor.typeTextIntoEditor(Keys.DELETE.toString()); | ||
| editor.waitAllMarkersInvisibility(ERROR); | ||
|
|
||
| // check adding comment code by keyboard 'Ctrl+/' |
There was a problem hiding this comment.
// check adding comment code by keyboard 'Ctrl+/' > // check code line commenting
There was a problem hiding this comment.
I would also move comment code verification into separate test checkCodeCommentFeature so that it doesn't connected to code validation feature.
| editor.goToCursorPositionVisible(13, 1); | ||
| editor.launchCommentCodeFeature(); | ||
| editor.waitTextIntoEditor("//package main"); | ||
| editor.launchCommentCodeFeature(); |
There was a problem hiding this comment.
// check code line uncommenting missed, IMHO
| editor.launchCommentCodeFeature(); | ||
| editor.waitTextIntoEditor("//package main"); | ||
| editor.launchCommentCodeFeature(); | ||
| editor.waitTextIntoEditor("package main"); |
There was a problem hiding this comment.
It doesn't actually check that "//" disappear, do it?
There was a problem hiding this comment.
Yes.. you are right )
| } | ||
|
|
||
| @Test(priority = 1) | ||
| public void checkRenameCodeFeature() { |
There was a problem hiding this comment.
Test method sounds a little bit strange: it is not about renaming the code - it is about renaming something inside the code, which is part of code.
So, I would propose to rename the test to checkRenameFeature
| // it is a workaround, need to fix after resolve the issue | ||
| try { | ||
| findReferencesConsoleTab.waitAllReferencesWithText( | ||
| "/desktop-go-simple/towers.go\n" + "From:23:71 To:23:76"); |
There was a problem hiding this comment.
Such concatenation at the middle of row looks weird.
| }; | ||
|
|
||
| private static final String[] PROJECT_SYMBOL_EXPECTED_TEXT = { | ||
| "print" + "/desktop-go-simple/format.go", "Print" + "/desktop-go-simple/print.go" |
There was a problem hiding this comment.
Concatenations inside the row look weird.
| "main" + "symbols (4)", "count", "hanoi", "main" | ||
| }; | ||
|
|
||
| private static final String[] PROJECT_SYMBOL_EXPECTED_TEXT = { |
There was a problem hiding this comment.
Looks like it is about FIND_SYMBOL_EXPECTED_TEXT, IMHO.
| assistantFindPanel.typeToInputField("print"); | ||
| assistantFindPanel.waitAllNodes(PROJECT_SYMBOL_EXPECTED_TEXT); | ||
|
|
||
| // select item in the find panel |
There was a problem hiding this comment.
// select item in the find panel by clicking on node
benoitf
removed
the
status/code-review
6 participants
What does this PR do?
What issues does this PR fix or reference?
#11209