Don't fail when jdt.ls messages are not found#11334
Merged
tsmaeder merged 1 commit intoeclipse-che:5730_java_ls_pocfrom Sep 25, 2018
Merged
Don't fail when jdt.ls messages are not found#11334tsmaeder merged 1 commit intoeclipse-che:5730_java_ls_pocfrom
tsmaeder merged 1 commit intoeclipse-che:5730_java_ls_pocfrom
Conversation
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder
added
status/code-review
tsmaeder
requested review from
Ohrimenko1988,
dmytro-ndp and
musienko-maxim
as code owners
tolusha
approved these changes
Sep 25, 2018
svor
approved these changes
Sep 25, 2018
Contributor
|
FYI: warnings in the test logs are usually treated as annoying and being ignored. You made verification useless so that they will not be reflected in test report, and they will be removed in near future. |
Contributor
Author
|
@dmytro-ndp it's not verification, we need to wait until jdt.ls has indexed the project before running java related tests. |
benoitf
removed
the
status/code-review
tsmaeder
added a commit
that referenced
this pull request
Sep 26, 2018
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder
added a commit
that referenced
this pull request
Oct 1, 2018
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder
added a commit
that referenced
this pull request
Oct 5, 2018
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder
added a commit
that referenced
this pull request
Oct 12, 2018
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder
added a commit
that referenced
this pull request
Oct 16, 2018
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder
added a commit
that referenced
this pull request
Oct 17, 2018
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder
added a commit
that referenced
this pull request
Oct 17, 2018
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder
added a commit
that referenced
this pull request
Oct 17, 2018
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder
added a commit
that referenced
this pull request
Oct 17, 2018
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder
added a commit
that referenced
this pull request
Oct 17, 2018
Signed-off-by: Thomas Mäder <tmader@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Instead of failing when initialization messages from jdt.ls are not found in the workspace machine console, just write out a warning message. The reaon is that we suspect that in the openshift runs of ci-tests, the ide is taking too long to start up and the console messages are never seen.
What issues does this PR fix or reference?
Don't fail when waiting for jdt.ls console messages #11328