Conversation
artaleks9
added
status/code-review
artaleks9
requested review from
Ohrimenko1988,
dmytro-ndp and
musienko-maxim
as code owners
SkorikSergey
approved these changes
Sep 25, 2018
dmytro-ndp
reviewed
Sep 25, 2018
| UBUNTU_GO("ubuntu_go.json"), | ||
| UBUNTU_JDK8("ubuntu_jdk8.json"), | ||
| UBUNTU_LSP("ubuntu_with_c_sharp_lsp.json"), | ||
| UBUNTU_CAMEL("ubuntu_jdk8_with_camel_ls.json"); |
Contributor
There was a problem hiding this comment.
It's not just "Apache Camel"(C) ls, but it is based on spring-boot image. More relevant name would sound like the following: spring_boot_with_apache_camel_ls.json
dmytro-ndp
reviewed
Sep 25, 2018
| private static final String PATH_TO_CAMEL_FILE = PROJECT_NAME + "/" + CAMEL_FILE_NAME; | ||
| private static final String LS_INIT_MESSAGE = | ||
| format("Finished language servers initialization, file path '/%s'", PATH_TO_CAMEL_FILE); | ||
| private static final String[] GO_TO_SYMBOL_EXPECTED_TEXT = {"<no id>symbols (2)", "<no id>"}; |
Contributor
There was a problem hiding this comment.
How about renaming it to EXPECTED_GO_TO_SYMBOL_ALTERNATIVES?
dmytro-ndp
approved these changes
Sep 25, 2018
benoitf
removed
the
status/code-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What issues does this PR fix or reference?
#11222