Setup default value for CHE_WORKSPACE_PLUGIN__REGISTRY__URL#11354
Merged
skabashnyuk merged 2 commits intomasterfrom Sep 26, 2018
Merged
Setup default value for CHE_WORKSPACE_PLUGIN__REGISTRY__URL#11354skabashnyuk merged 2 commits intomasterfrom
skabashnyuk merged 2 commits intomasterfrom
Conversation
skabashnyuk
requested review from
Ohrimenko1988,
dmytro-ndp,
garagatyi,
l0rd,
musienko-maxim,
riuvshin and
sleshchenko
as code owners
Contributor
Author
|
ci-test |
benoitf
added
status/code-review
l0rd
approved these changes
Sep 26, 2018
sleshchenko
approved these changes
Sep 26, 2018
| optional: true | ||
| - name: CHE_WORKSPACE_PLUGIN__REGISTRY__URL | ||
| value: 'NULL' | ||
| value: 'https://che-plugin-registry.openshift.io' |
Member
There was a problem hiding this comment.
I believe this yaml file is not used for deploying Che on the OpenShift. I think it doesn't make sense to update it. It would be even better to replace this Che Deployment Config yaml with simpler yaml which is needed for nodejs-with-yaml testing
@eclipse/eclipse-che-qa Please correct me if I'm wrong and this test requires actual Che Server configuration.
Contributor
|
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
garagatyi
approved these changes
Sep 26, 2018
benoitf
removed
the
status/code-review
nickboldt
pushed a commit
to nickboldt/che
that referenced
this pull request
Oct 3, 2018
…che#11354) Setup default value for CHE_WORKSPACE_PLUGIN__REGISTRY__URL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Setup default value for CHE_WORKSPACE_PLUGIN__REGISTRY__URL
What issues does this PR fix or reference?
Fixes #11352
Release Notes
n/a
Docs PR
n/a