Skip to content

Add possibility to configure timeout for plugin broker#11368

Merged
mshaposhnik merged 4 commits intomasterfrom
che-11120
Sep 27, 2018
Merged

Add possibility to configure timeout for plugin broker#11368
mshaposhnik merged 4 commits intomasterfrom
che-11120

Conversation

@mshaposhnik
Copy link
Copy Markdown
Contributor

@mshaposhnik mshaposhnik commented Sep 26, 2018

What does this PR do?

Add configuration for result waiting timeout in plugin broker

What issues does this PR fix or reference?

#11120

Release Notes

N/A

Docs PR

N/A

@benoitf benoitf added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. labels Sep 26, 2018
sleshchenko
sleshchenko approved these changes Sep 26, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@sleshchenko sleshchenko left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Please take a look my inlined comment before a merge

assembly/assembly-wsmaster-war/src/main/webapp/WEB-INF/classes/che/che.properties Outdated
che.infra.kubernetes.ingress_start_timeout_min=5

# Defines the timeout in minutes that limits the max period of result waiting for plugin broker.
che.infra.kubernetes.plugin_broker_wait_timeout_min=3
Copy link
Copy Markdown
Member

@sleshchenko sleshchenko Sep 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename it in the way in which other plugin broker properties are named, like che.workspace.plugin_broker.wait_timeout_min:
https://github.com/eclipse/che/blob/d82481bff1f08383637c84cab1a36d1a65c242bf/assembly/assembly-wsmaster-war/src/main/webapp/WEB-INF/classes/che/che.properties#L510-L514

And put it near them

@mshaposhnik
Copy link
Copy Markdown
Contributor Author

mshaposhnik commented Sep 26, 2018

@garagatyi do we need something more than that? Some openshift specific mappings?

@garagatyi
Copy link
Copy Markdown

garagatyi commented Sep 26, 2018

nothing else

@mshaposhnik
Copy link
Copy Markdown
Contributor Author

mshaposhnik commented Sep 26, 2018

ci-test

@riuvshin
Copy link
Copy Markdown
Contributor

riuvshin commented Sep 26, 2018

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:11368
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@mshaposhnik
Copy link
Copy Markdown
Contributor Author

mshaposhnik commented Sep 26, 2018

ci-test

@riuvshin
Copy link
Copy Markdown
Contributor

riuvshin commented Sep 26, 2018

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:11368
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@mshaposhnik
Copy link
Copy Markdown
Contributor Author

mshaposhnik commented Sep 26, 2018

ci-test

@riuvshin
Copy link
Copy Markdown
Contributor

riuvshin commented Sep 26, 2018

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:11368
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@mshaposhnik mshaposhnik merged commit ce31146 into master Sep 27, 2018
@mshaposhnik mshaposhnik deleted the che-11120 branch September 27, 2018 06:52
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Sep 27, 2018
@benoitf benoitf added this to the 6.12.0 milestone Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sleshchenko sleshchenko sleshchenko approved these changes

@riuvshin riuvshin Awaiting requested review from riuvshin

@skabashnyuk skabashnyuk Awaiting requested review from skabashnyuk

+1 more reviewer

@garagatyi garagatyi garagatyi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

kind/task Internal things, technical debt, and to-do tasks to be performed.

Projects

None yet

Milestone

6.12.0

Development

Successfully merging this pull request may close these issues.

5 participants

@mshaposhnik @garagatyi @riuvshin @sleshchenko @benoitf