Conversation
artaleks9
added
status/code-review
artaleks9
requested review from
Ohrimenko1988 and
musienko-maxim
as code owners
SkorikSergey
approved these changes
Sep 27, 2018
dmytro-ndp
reviewed
Sep 28, 2018
| prepareFilesForTest(jsFileName); | ||
| prepareFilesForTest(htmlFileName); | ||
| prepareFilesForTest(folderWithPlainFilesPath + "/" + readmeTxtFileName); | ||
| prepareFilesForTest(folderWithPlainFilesPath + "/README.md"); |
Contributor
There was a problem hiding this comment.
Let's create the constant for that name as well:
private final static String README_MD_FILE_NAME = "README.md";
Contributor
Author
There was a problem hiding this comment.
OK, I'll correct, but may be there is sense to do it as a local variable?
That to keep some uniformity in the test.
String readmeMdFileName = "README.md";
dmytro-ndp
approved these changes
Sep 28, 2018
benoitf
removed
the
status/code-review
nickboldt
pushed a commit
to nickboldt/che
that referenced
this pull request
Oct 3, 2018
…ce (eclipse-che#11389) * Selenium: Correct the 'GitPullTest' related to unexpected stale reference
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In fact we delete the folder with test files and as result after git pull these files are deleted from the editor and the project explorer.
On my opinion, we should check that test files are really delete from editor (the tab file names are not present), and to exclude the check of text unpresent in the editor.
What issues does this PR fix or reference?
#11223