Skip to content

Adapt "open declaration" tests to behaviour of LSP editors#11448

Merged
tsmaeder merged 1 commit intoeclipse-che:5730_java_ls_pocfrom
tsmaeder:11431_opendeclaration_tests
Oct 2, 2018
Merged

Adapt "open declaration" tests to behaviour of LSP editors#11448
tsmaeder merged 1 commit intoeclipse-che:5730_java_ls_pocfrom
tsmaeder:11431_opendeclaration_tests

Conversation

@tsmaeder
Copy link
Copy Markdown
Contributor

@tsmaeder tsmaeder commented Oct 2, 2018

What does this PR do?

Adapts opendeclaration package of selenium tests to the fact that the Java editor now is a LSP editor and as such behaves the same in "open declaration".
Also, added code to print expected and actual values when checking for editor position

What issues does this PR fix or reference?

Partial fix of:
#11431

Signed-off-by: Thomas Mäder <tmader@redhat.com>
@tsmaeder tsmaeder added target/branch Indicates that a PR will be merged into a branch other than master. e2e-test/failure Issues that is related to a test failures reported by our CI platform and our QE. team/languages labels Oct 2, 2018
@tsmaeder tsmaeder merged commit b184931 into eclipse-che:5730_java_ls_poc Oct 2, 2018
@benoitf benoitf added the kind/bug Outline of a bug - must adhere to the bug report template. label Oct 2, 2018
tsmaeder added a commit that referenced this pull request Oct 5, 2018
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder added a commit that referenced this pull request Oct 12, 2018
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder added a commit that referenced this pull request Oct 16, 2018
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder added a commit that referenced this pull request Oct 17, 2018
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder added a commit that referenced this pull request Oct 17, 2018
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder added a commit that referenced this pull request Oct 17, 2018
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder added a commit that referenced this pull request Oct 17, 2018
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder added a commit that referenced this pull request Oct 17, 2018
Signed-off-by: Thomas Mäder <tmader@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e-test/failure Issues that is related to a test failures reported by our CI platform and our QE. kind/bug Outline of a bug - must adhere to the bug report template. target/branch Indicates that a PR will be merged into a branch other than master.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants