Added liveness probe for jupyter server#11454
Merged
sleshchenko merged 2 commits intoeclipse-che:masterfrom Oct 4, 2018
Merged
Added liveness probe for jupyter server#11454sleshchenko merged 2 commits intoeclipse-che:masterfrom
sleshchenko merged 2 commits intoeclipse-che:masterfrom
Conversation
sleshchenko
added
the
status/code-review
benoitf
added
the
kind/task
Member
Author
|
ci-test |
skabashnyuk
approved these changes
Oct 3, 2018
garagatyi
reviewed
Oct 3, 2018
| this.timer = new Timer("ServersChecker", true); | ||
| this.machineTokenProvider = machineTokenProvider; | ||
| this.serverPingSuccessThreshold = serverPingSuccessThreshold; | ||
| this.livenessProbes = |
Member
Author
There was a problem hiding this comment.
Thanks for pointing. I'll check
garagatyi
approved these changes
Oct 3, 2018
Member
Author
|
ci-test |
Contributor
|
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
Contributor
|
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
riuvshin
approved these changes
Oct 4, 2018
sleshchenko
force-pushed
the
serversLivenessProbes
branch
2 times, most recently
from
8bbe897 to
8a9ed32
Compare
sleshchenko
force-pushed
the
serversLivenessProbes
branch
from
8a9ed32 to
1150582
Compare
sleshchenko
added a commit
that referenced
this pull request
Oct 4, 2018
benoitf
removed
the
status/code-review
nickboldt
pushed a commit
to nickboldt/che
that referenced
this pull request
Oct 4, 2018
nickboldt
pushed a commit
to nickboldt/che
that referenced
this pull request
Oct 4, 2018
nickboldt
pushed a commit
to nickboldt/che
that referenced
this pull request
Oct 5, 2018
nickboldt
pushed a commit
to nickboldt/che
that referenced
this pull request
Oct 5, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Since there is jypyter editor in plugin registry it is needed to have liveness probe for it.
Also, this PR moves list of servers which requires liveness probe to the configuration. It allows configuring new server if it is needed, like when custom plugin registry is used where new editor is available.
What issues does this PR fix or reference?
#11383
Release Notes
N/A
Docs PR
N/A