Limit pool size used to process Json/rpc requests by skabashnyuk · Pull Request #11456 · eclipse-che/che

skabashnyuk · 2018-10-03T11:40:22Z

What does this PR do?

Limit pool size used to process Json/rpc requests

What issues does this PR fix or reference?

#5443

Release Notes

n/a

Docs PR

n/a

garagatyi · 2018-10-03T11:49:55Z

...api-core/src/main/java/org/eclipse/che/api/core/jsonrpc/impl/ServerSideRequestProcessor.java

+
+  @Inject
+  public ServerSideRequestProcessor(
+      @Named("che.server.jsonrpc.processor_pool_size") String poolSize) {


We can inject int instead of String.

skabashnyuk · 2018-10-03T11:55:44Z

ci-test

…requests

sleshchenko · 2018-10-03T12:03:25Z

assembly/assembly-wsmaster-war/src/main/webapp/WEB-INF/classes/che/che.properties

 che.server.secure_exposer.jwtproxy.memory_limit=128mb
+
+# Maximum size of the json processing pool
+che.server.jsonrpc.processor_max_pool_size=100


I don't think that this property is related to Che Server. Please consider renaming it to something more common like che.core.jsonrpc... or che.jsonrpc.... . Also, it makes sense to place it near WebSocket related properties.

assembly/assembly-wsmaster-war/src/main/webapp/WEB-INF/classes/che/che.properties

 che.server.secure_exposer.jwtproxy.image=eclipse/che-jwtproxy:latest
 che.server.secure_exposer.jwtproxy.memory_limit=128mb
+
+# Maximum size of the json processing pool


sleshchenko · 2018-10-03T12:04:49Z

...api-core/src/main/java/org/eclipse/che/api/core/jsonrpc/impl/ServerSideRequestProcessor.java

+  private final int maxPoolSize;
+
+  @Inject
+  public ServerSideRequestProcessor(@Named("che.server.jsonrpc.processor_max_pool_size") int maxPoolSize) {


don't forget to rename here as well

riuvshin · 2018-10-03T12:08:33Z

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:11456
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

…on/rpc requests

skabashnyuk · 2018-10-03T12:35:32Z

ci-test

riuvshin · 2018-10-03T12:42:26Z

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:11456
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

…cess Json/rpc requests

skabashnyuk · 2018-10-03T13:36:08Z

ci-test

riuvshin · 2018-10-03T14:02:49Z

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:11456
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

… to process Json/rpc requests

skabashnyuk · 2018-10-03T15:03:05Z

ci-test

riuvshin · 2018-10-03T17:57:15Z

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:11456
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

skabashnyuk · 2018-10-04T05:47:22Z

@eclipse/eclipse-che-qa can you take a look?

skabashnyuk · 2018-10-04T05:56:13Z

ci-test

riuvshin · 2018-10-04T09:00:42Z

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:11456
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

…ze used to process Json/rpc requests

skabashnyuk · 2018-10-04T10:24:57Z

ci-test

riuvshin · 2018-10-04T13:28:56Z

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:11456
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

mshaposhnik · 2018-10-04T14:40:36Z

ci-test

riuvshin · 2018-10-04T19:57:58Z

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:11456
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

skabashnyuk · 2018-10-05T10:20:46Z

ci-test

riuvshin · 2018-10-05T13:21:06Z

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:11456
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

artaleks9 · 2018-10-05T13:54:49Z

Selenium tests execution on Eclipse Che Multiuser on OCP (https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/930/) doesn't show any regression against this Pull Request.

Limit pool size used to process Json/RPC requests (eclipse-che#11456)

Limit pool size used to process Json/RPC requests (#11456)

Limit pool size used to process Json/rpc requests

ddada92

skabashnyuk requested a review from riuvshin as a code owner October 3, 2018 11:40

skabashnyuk requested review from dkulieshov, garagatyi and sleshchenko October 3, 2018 11:40

fixup! Limit pool size used to process Json/rpc requests

acd8701

benoitf added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/bug Outline of a bug - must adhere to the bug report template. labels Oct 3, 2018

garagatyi approved these changes Oct 3, 2018

View reviewed changes

fixup! fixup! Limit pool size used to process Json/rpc requests

dbe43b5

skabashnyuk added 2 commits October 3, 2018 14:57

fixup! fixup! fixup! Limit pool size used to process Json/rpc requests

c353023

fixup! fixup! fixup! fixup! Limit pool size used to process Json/rpc …

46103f1

…requests

sleshchenko approved these changes Oct 3, 2018

View reviewed changes

fixup! fixup! fixup! fixup! fixup! Limit pool size used to process Js…

e2684a4

…on/rpc requests

fixup! fixup! fixup! fixup! fixup! fixup! Limit pool size used to pro…

739c70a

…cess Json/rpc requests

dkulieshov approved these changes Oct 3, 2018

View reviewed changes

fixup! fixup! fixup! fixup! fixup! fixup! fixup! Limit pool size used…

6c57aa7

… to process Json/rpc requests

skabashnyuk requested a review from tolusha as a code owner October 3, 2018 15:02

riuvshin approved these changes Oct 3, 2018

View reviewed changes

tolusha approved these changes Oct 4, 2018

View reviewed changes

fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Limit pool si…

d094e7b

…ze used to process Json/rpc requests

Increase pool size

1828c0a

skabashnyuk added 2 commits October 5, 2018 10:35

Merge remote-tracking branch 'origin/master' into i5443

3a2fe92

fixup! Merge remote-tracking branch 'origin/master' into i5443

1a9b866

skabashnyuk merged commit ad8fd5e into master Oct 5, 2018

skabashnyuk deleted the i5443 branch October 5, 2018 13:56

nickboldt pushed a commit to nickboldt/che that referenced this pull request Oct 5, 2018

Limit pool size used to process Json/rpc requests (eclipse-che#11456)

7b1a565

Limit pool size used to process Json/RPC requests (eclipse-che#11456)

nickboldt pushed a commit to nickboldt/che that referenced this pull request Oct 5, 2018

Limit pool size used to process Json/rpc requests (eclipse-che#11456)

0de2079

Limit pool size used to process Json/RPC requests (eclipse-che#11456)

skabashnyuk mentioned this pull request Oct 8, 2018

Create 6.12.1 bugfix release #11529

Closed

riuvshin pushed a commit that referenced this pull request Oct 8, 2018

Limit pool size used to process Json/rpc requests (#11456)

63a67d0

Limit pool size used to process Json/RPC requests (#11456)

benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Oct 9, 2018

benoitf added this to the 6.13.0 milestone Oct 9, 2018

Conversation

skabashnyuk commented Oct 3, 2018

What does this PR do?

What issues does this PR fix or reference?

Release Notes

Docs PR

Uh oh!

garagatyi Oct 3, 2018

Choose a reason for hiding this comment

Uh oh!

skabashnyuk commented Oct 3, 2018

Uh oh!

sleshchenko Oct 3, 2018

Choose a reason for hiding this comment

Uh oh!

This comment was marked as resolved.

Uh oh!

sleshchenko Oct 3, 2018

Choose a reason for hiding this comment

Uh oh!

riuvshin commented Oct 3, 2018

Uh oh!

skabashnyuk commented Oct 3, 2018

Uh oh!

riuvshin commented Oct 3, 2018

Uh oh!

skabashnyuk commented Oct 3, 2018

Uh oh!

riuvshin commented Oct 3, 2018

Uh oh!

skabashnyuk commented Oct 3, 2018

Uh oh!

riuvshin commented Oct 3, 2018

Uh oh!

skabashnyuk commented Oct 4, 2018

Uh oh!

skabashnyuk commented Oct 4, 2018

Uh oh!

riuvshin commented Oct 4, 2018

Uh oh!

skabashnyuk commented Oct 4, 2018

Uh oh!

riuvshin commented Oct 4, 2018

Uh oh!

mshaposhnik commented Oct 4, 2018

Uh oh!

riuvshin commented Oct 4, 2018

Uh oh!

skabashnyuk commented Oct 5, 2018

Uh oh!

riuvshin commented Oct 5, 2018

Uh oh!

artaleks9 commented Oct 5, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants