Skip to content

Disable debug mode for wsagent by default#11475

Merged
sleshchenko merged 3 commits intoeclipse-che:masterfrom
sleshchenko:wsagentInstallerDebug
Oct 4, 2018
Merged

Disable debug mode for wsagent by default#11475
sleshchenko merged 3 commits intoeclipse-che:masterfrom
sleshchenko:wsagentInstallerDebug

Conversation

@sleshchenko
Copy link
Copy Markdown
Member

@sleshchenko sleshchenko commented Oct 4, 2018 •
edited
Loading

What does this PR do?

It contains two separate changes:

  1. Add an ability to configure debug mode for wsagent with env vars. There are the following env vars:
  • WSAGENT_DEBUG - to enable or disable JPDA mode for wsagent tomcat, false by default;
  • WSAGENT_DEBUG_PORT - to configure JPDA port, 4403 by default;
  • WSAGENT_DEBUG_SUSPEND - to configure JPDA suspend mode, n by default.
  1. Disables debug mode for wsagent by default. It is needed to remove debug server as well since bootstrapper wait until all servers ports will be busy.

There are two reasons to disable wsagent debug mode by default:

  1. It is needed because debug mode is not a thing that should be enabled by default.
  2. Debug mode produces STDERR which is logged in Che Servers logs and published to clients but it is not really an issue which leads to agent failing. Here is a error line which is mentioned before
    Debugger failed to attach: handshake failed - connection prematurally closed

What issues does this PR fix or reference?

#10833

Release Notes

Docs PR

N/A

@sleshchenko sleshchenko added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Oct 4, 2018
@sleshchenko sleshchenko self-assigned this Oct 4, 2018
@sleshchenko sleshchenko requested review from a user, garagatyi and skabashnyuk October 4, 2018 09:24
@sleshchenko sleshchenko requested a review from tolusha as a code owner October 4, 2018 09:24
@benoitf benoitf added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Oct 4, 2018
@sleshchenko
Copy link
Copy Markdown
Member Author

sleshchenko commented Oct 4, 2018

ci-test

@riuvshin
Copy link
Copy Markdown
Contributor

riuvshin commented Oct 4, 2018

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:11475
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@sleshchenko sleshchenko force-pushed the wsagentInstallerDebug branch from 092fcbd to c8beed6 Compare October 4, 2018 15:23
@sleshchenko sleshchenko merged commit 409d4c1 into eclipse-che:master Oct 4, 2018
@sleshchenko sleshchenko deleted the wsagentInstallerDebug branch October 4, 2018 15:44
sleshchenko added a commit that referenced this pull request Oct 4, 2018
@sleshchenko
Remove wsagent debug server from installer (PR #11475)
f6a196a
sleshchenko added a commit that referenced this pull request Oct 4, 2018
@sleshchenko
Add an ability to configure wsagent debug mode with env vars (PR #11475)
41685cd
@Ohrimenko1988 Ohrimenko1988 mentioned this pull request Oct 5, 2018
Merged
nickboldt pushed a commit to nickboldt/che that referenced this pull request Oct 5, 2018
@sleshchenko @nickboldt
Remove wsagent debug server from installer (PR eclipse-che#11475)
1e17a5b
nickboldt pushed a commit to nickboldt/che that referenced this pull request Oct 5, 2018
@sleshchenko @nickboldt
Add an ability to configure wsagent debug mode with env vars (PR ecli…
455e334 
…pse-che#11475)
nickboldt pushed a commit to nickboldt/che that referenced this pull request Oct 5, 2018
@sleshchenko @nickboldt
Do not enable debug mode for wsagent by default (PR eclipse-che#11475)
94fd1b7
nickboldt pushed a commit to nickboldt/che that referenced this pull request Oct 5, 2018
@sleshchenko @nickboldt
Remove wsagent debug server from installer (PR eclipse-che#11475)
2cab05d
nickboldt pushed a commit to nickboldt/che that referenced this pull request Oct 5, 2018
@sleshchenko @nickboldt
Add an ability to configure wsagent debug mode with env vars (PR ecli…
ca803db 
…pse-che#11475)
nickboldt pushed a commit to nickboldt/che that referenced this pull request Oct 5, 2018
@sleshchenko @nickboldt
Do not enable debug mode for wsagent by default (PR eclipse-che#11475)
5846879
@skabashnyuk skabashnyuk mentioned this pull request Oct 8, 2018
Closed
riuvshin pushed a commit that referenced this pull request Oct 8, 2018
@sleshchenko
Remove wsagent debug server from installer (PR #11475)
98b2d65
riuvshin pushed a commit that referenced this pull request Oct 8, 2018
@sleshchenko
Add an ability to configure wsagent debug mode with env vars (PR #11475)
a2342c6
riuvshin pushed a commit that referenced this pull request Oct 8, 2018
@sleshchenko
Do not enable debug mode for wsagent by default (PR #11475)
423ef54
@benoitf benoitf added this to the 6.13.0 milestone Oct 9, 2018
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Oct 9, 2018
@skabashnyuk skabashnyuk mentioned this pull request Oct 19, 2018
Closed
@amisevsk amisevsk mentioned this pull request Nov 27, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skabashnyuk skabashnyuk skabashnyuk approved these changes

@tolusha tolusha tolusha approved these changes

+2 more reviewers

@garagatyi garagatyi garagatyi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sleshchenko sleshchenko

Labels

kind/task Internal things, technical debt, and to-do tasks to be performed.

Projects

None yet

Milestone

6.13.0

Development

Successfully merging this pull request may close these issues.

6 participants

@sleshchenko @riuvshin @skabashnyuk @tolusha @garagatyi @benoitf