Remove deploy.sh #16376
Merged
Remove deploy.sh #16376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
tolusha
requested review from
l0rd,
nickboldt,
rhopp and
sleshchenko
as code owners
che-bot
added
status/code-review
benoitf
approved these changes
Mar 17, 2020
Contributor
|
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1) |
skabashnyuk
approved these changes
Mar 17, 2020
che-bot
removed
the
status/code-review
24 tasks
Member
|
@tolusha could you clarify why the script was removed, but all the templates are still there? |
8 tasks
Contributor
Author
|
@ibuziuk |
Member
|
AFAIK no cc: @skabashnyuk |
Contributor
|
yeh. this part https://github.com/eclipse/che/tree/master/deploy/openshift/templates/monitoring is still used. We are going to replace it with operator logic soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anatoliy Bazko abazko@redhat.com
What does this PR do?
Removes
deploy.shocp.shscripts as deprecated.What issues does this PR fix or reference?
#13888