Issue 8721 - Update Libraries, etc. based on JDT notifications #8721#9650
Merged
tsmaeder merged 1 commit intoeclipse-che:5730_java_ls_pocfrom Jun 6, 2018
Merged
Issue 8721 - Update Libraries, etc. based on JDT notifications #8721#9650tsmaeder merged 1 commit intoeclipse-che:5730_java_ls_pocfrom
tsmaeder merged 1 commit intoeclipse-che:5730_java_ls_pocfrom
Conversation
vrubezhny
requested review from
evidolob,
garagatyi,
l0rd,
riuvshin,
sleshchenko and
vparfonov
as code owners
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
benoitf
added
kind/enhancement
|
Can one of the admins verify this patch? |
tsmaeder
requested changes
May 11, 2018
| if (CLIENT_UPDATE_PROJECTS_CLASSPATH.equals(params.getCommand())) { | ||
| for (Object project : params.getArguments()) { | ||
| eventBus.fireEvent( | ||
| new ExternalLibrariesUpdateEvent(removePrefixUri(String.valueOf(project)))); |
Contributor
There was a problem hiding this comment.
I generally name events after what has happened, in this case that would be sth. like "ProjectClasspathChangedEvent".
| if (CLIENT_UPDATE_PROJECTS_CLASSPATH.equals(params.getCommand())) { | ||
| for (Object project : params.getArguments()) { | ||
| eventBus.fireEvent( | ||
| new ExternalLibrariesUpdateEvent(removePrefixUri(String.valueOf(project)))); |
Contributor
There was a problem hiding this comment.
JSonValue.toString() is broken for strings, see also #7725. We really should use JSonString.stringValue().
| } | ||
|
|
||
| public CompletableFuture<Object> executeClientCommand(ExecuteCommandParams params) { | ||
| return executeCliendCommandTransmitter.executeClientCommand(params); |
Contributor
There was a problem hiding this comment.
This is a place where we could recognize specific commands and transform file:///projects uri's.
| } | ||
|
|
||
| private static String removePrefixUri(String uri) { | ||
| String projectPath = uri.startsWith("\"") ? uri.substring("\"".length()) : uri; |
Contributor
There was a problem hiding this comment.
This should happen in WSMaster, as explained in Chat.
tsmaeder
force-pushed
the
5730_java_ls_poc
branch
2 times, most recently
from
6901019 to
518f5f6
Compare
…e-che#8721 Added a listener for CLASSPATH change events that updates External Libraries nodes accordingly Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
tsmaeder
approved these changes
Jun 6, 2018
benoitf
removed
the
status/code-review
tsmaeder
pushed a commit
that referenced
this pull request
Jun 13, 2018
tsmaeder
pushed a commit
that referenced
this pull request
Jun 13, 2018
tsmaeder
pushed a commit
that referenced
this pull request
Jun 26, 2018
tsmaeder
pushed a commit
that referenced
this pull request
Jul 13, 2018
tsmaeder
pushed a commit
that referenced
this pull request
Jul 27, 2018
tolusha
pushed a commit
that referenced
this pull request
Aug 7, 2018
tsmaeder
pushed a commit
that referenced
this pull request
Aug 22, 2018
tsmaeder
pushed a commit
that referenced
this pull request
Aug 29, 2018
tolusha
pushed a commit
that referenced
this pull request
Sep 5, 2018
tsmaeder
pushed a commit
that referenced
this pull request
Sep 13, 2018
tsmaeder
pushed a commit
that referenced
this pull request
Sep 20, 2018
tsmaeder
pushed a commit
that referenced
this pull request
Sep 26, 2018
tsmaeder
pushed a commit
that referenced
this pull request
Oct 1, 2018
tsmaeder
pushed a commit
that referenced
this pull request
Oct 5, 2018
tsmaeder
pushed a commit
that referenced
this pull request
Oct 12, 2018
tsmaeder
pushed a commit
that referenced
this pull request
Oct 16, 2018
tsmaeder
pushed a commit
that referenced
this pull request
Oct 17, 2018
tsmaeder
pushed a commit
that referenced
this pull request
Oct 17, 2018
(#9650) Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 17, 2018
(#9650) Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 17, 2018
(#9650) Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 17, 2018
(#9650) Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The fix adds a listener for 'che.jdt.ls.extension.workspace.clientUpdateProjectsClasspath" events and updates an according "External Libraries" node in Project Explorer.
What issues does this PR fix or reference?
Fixes #8721
Depends on eclipse-che/che-ls-jdt#44
Release Notes
Project Explorer tree now listens for the "Update Classpath" events of che-jdt-ls and updates "External Libraries" node of java project that is indicated in the event data.
Docs PR