Skip to content

Remove unnecessary pageobjects. Rename MachineTerminal page object to CheTerminal#9665

Merged
musienko-maxim merged 1 commit intomasterfrom
quick_fix_for_machine_perspective
Jun 8, 2018
Merged

Remove unnecessary pageobjects. Rename MachineTerminal page object to CheTerminal#9665
musienko-maxim merged 1 commit intomasterfrom
quick_fix_for_machine_perspective

Conversation

@musienko-maxim
Copy link
Copy Markdown
Contributor

What does this PR do?

  • We had package and 2 unnecessary pageobject: CreateMachineWidget.java and MachineInformationTab.java which described MachinePerspective view. This view was removed. Therefore we should also remove this entities.
  • MachineTerminal name is not actual because the terminal has been relocated from MachinePerspective view to Main IDE View

…tive view. Rename MachineTerminal to CheTerminal
@musienko-maxim musienko-maxim requested a review from vparfonov as a code owner May 10, 2018 12:42
@musienko-maxim musienko-maxim changed the title Remove unnecessary pageobjects related with depricated MachinePerspec… Remove unnecessary pageobjects. Rename MachineTerminal page object to CheTerminal May 10, 2018
@benoitf benoitf added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label May 10, 2018
@musienko-maxim
Copy link
Copy Markdown
Contributor Author

ci-build

@codenvy-ci
Copy link
Copy Markdown

@musienko-maxim musienko-maxim merged commit 344daee into master Jun 8, 2018
@musienko-maxim musienko-maxim deleted the quick_fix_for_machine_perspective branch June 8, 2018 09:37
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jun 8, 2018
@benoitf benoitf added this to the 6.7.0 milestone Jun 8, 2018
hbhargav pushed a commit to hbhargav/che that referenced this pull request Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants